public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: GOTO Masanori <gotom@debian.or.jp>
To: arjanv@redhat.com
Cc: Steve Youngs <sryoungs@bigpond.net.au>,
	Linux Kernel List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Increase recursive symlink limit from 5 to 8
Date: Fri, 16 Jan 2004 09:45:47 +0900	[thread overview]
Message-ID: <817jzsd8lg.wl@omega.webmasters.gr.jp> (raw)
In-Reply-To: <1073814570.4431.3.camel@laptop.fenrus.com>

At Sun, 11 Jan 2004 10:49:30 +0100,
Arjan van de Ven wrote:
> > 6 does seem pretty low.  What was the reason for setting it there?  Is
> > there a downside to increasing it?
> 
> It was reduced down from 8 because it can lead to stack overflows.
> Recursive links like this usually point at a quite broken filesystem
> setup too afaik.

But I still think 6 is too small from user level point of view, as
Petter wrote.  The example is /usr/lib library links.  I got bug
report which complained that a library want to use "bounce" link:

	/usr/lib/liba -> /etc/alternatives/liba -> /usr/lib/another/libb.

If .so file uses major.minor scheme, then /usr/lib/liba.so links:

	/usr/lib/liba.so -> /usr/lib/liba.so.2 -> /usr/lib/liba.so.2.3

and so on.  It can easily exceed 6 symlinks.  I think the correct fix
is to make VFS not to overflow stacks.  Is it allowable change?

Regards,
-- gotom


  reply	other threads:[~2004-01-16  0:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-07 23:12 [PATCH] Increase recursive symlink limit from 5 to 8 Petter Reinholdtsen
2004-01-11  1:03 ` Petter Reinholdtsen
2004-01-11  7:01   ` Steve Youngs
2004-01-11  9:37     ` Peter Osterlund
2004-01-11  9:49     ` Arjan van de Ven
2004-01-16  0:45       ` GOTO Masanori [this message]
2004-01-16  0:56         ` Måns Rullgård
2004-01-16  1:25         ` viro
2004-01-16 15:46           ` Andries Brouwer
2004-01-16  3:08         ` Steve Youngs
2004-01-11 12:10     ` Felipe Alfaro Solana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=817jzsd8lg.wl@omega.webmasters.gr.jp \
    --to=gotom@debian.or.jp \
    --cc=arjanv@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sryoungs@bigpond.net.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox