From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60E8F26B77A for ; Wed, 2 Jul 2025 11:04:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751454253; cv=none; b=bJE5va6t+1V0gOT3BnPoKfdHsfehYMU7In7cJv9vHfE/zY7QEKmQIzFSUmBvr6kfNyFstPOtbI/Y+UR7TTN8SuTt+t1H9hCwO1JU6xTYmyz8FV78RfFrulAFnKLR6VSDBaD5cKKe2XrMF1Um3TXT4/x8kcyU9Neagn+XAA+CxMU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751454253; c=relaxed/simple; bh=d8G1yolRdxXqc9ogkL/VOw8lB8sVwSzbF3ORDXjZyUE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nZKBV2Ups+sA/vXDSLlRWjHWRJvy1zwGjtgkdgLf+do49L0jwjYyc3e1IB2vzSYgZ1Q8i+m+PDqeF42pkrh7GBhuRYzVehS84szvRHiwJZKDzGH/catKeLGmyfXRB1tBR9JyufdHD7tIPvYg80U3antlmahRSXtLr4ZInWytJbk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Z37fdF7B; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Z37fdF7B" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751454251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Zw0KvQ+k4rubnSzWXk9d6NL2jyCuYlOPMDEvtfYHEhw=; b=Z37fdF7Bm8q9r3FTzreVgbR7gOIsKHTts7CJPgn9T2wjQN4fLR6HAyBe+6aqQ3h9cMSvJh gBAKn6aIIvtXXhmVFx1aMj/iNh+wkpARSsnUnaeqfbD/fkk+xIRTqAvGB/lkaz45X3Qrch EcNp5VeSXMahM3dTUyXnt5UJP0u4/JI= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-130-N76gtW8QPj6RYtTofbcZmQ-1; Wed, 02 Jul 2025 07:04:10 -0400 X-MC-Unique: N76gtW8QPj6RYtTofbcZmQ-1 X-Mimecast-MFC-AGG-ID: N76gtW8QPj6RYtTofbcZmQ_1751454249 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a50049f8eeso3377514f8f.3 for ; Wed, 02 Jul 2025 04:04:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751454249; x=1752059049; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Zw0KvQ+k4rubnSzWXk9d6NL2jyCuYlOPMDEvtfYHEhw=; b=jI7kaEy5/EF79v9aCuiMX3IsgdDeK+1vvWbos1oddTTUUEV9vTYI/d0SLJqXyON3Fv K8ivRk09enx3RfwKDJEdEkTGmWAAfc5NdLPWrQXiOFWFH2xVLL+k52vmbcDosMpePbDS SYT7/XiZBpmZ3hES28//xpG8jScq/uGNqRZySASO1FlP4ltE2837Xgzl+plSFT3j//9t +3josSJT0XNQsE3t+92SMOPrYSmyanOy1Sui2o/cwBuJLUMdgT4HloW07SzJlTyB7aVH LQ1T9Fy+SIxPytU5J3fVRmo5veEoJvuNX7LX2XMZR3okWic2DComO9XzFbhinn8VrgNg NZpQ== X-Gm-Message-State: AOJu0YzBQURBL70baxrkFJtoh3CavlduPCQVj9OeyocjlAq3+WwBuC0h gl+mbcQPJGZS3lXV++S0pDcC1lABlhPzEJljhvcVQiX1QLh7m4kwetq+Il2Mb0wt58x3wkvU0Oz iIFFqbOrcGgIruTihXDex+2AvCAo1WzCcdYIA/NIlxMArwBQkqhBOmQc8Ykd3iSQs4g== X-Gm-Gg: ASbGncu8DNbfWyzkWRCDWbmwBNmAGf9faxdJo2wm7x1Qu+qWymShiNYtJzXqs+rWuSQ yhcATM/k1rMLaTu04KpRwEjthyU8QjRmYc4NLct8mE1L1RW8h5UP9fGfmLQi5XWDptsub9WR4EJ CJtmg2w0co6mVYWie8RSqeiU2/cvxVgNwbaasZz0i9XK1ZaNmQJRnGUfxximw/3Xy9WXtTDk00r UCOHf98V5IFOIwelxu9WQ4h0WejYkUinE5pLQXwfFtCxM5pRRm1ScQxRmAsa92m46XyCQbW6R4E 40u1sMXt4otZvs+yExlTN3fd7I4FkMVbCALFzgX5/NX/jSkyhl3haaU= X-Received: by 2002:a05:6000:2082:b0:3a4:f63b:4bfc with SMTP id ffacd0b85a97d-3b2000b024emr1814762f8f.34.1751454248690; Wed, 02 Jul 2025 04:04:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFOT/aw8XAmzCSK/ne3sEgcVpZYgHkoY1cnPnlo+cO4h4gm0Yl02x2OdxUmHov75EY70Jiegg== X-Received: by 2002:a05:6000:2082:b0:3a4:f63b:4bfc with SMTP id ffacd0b85a97d-3b2000b024emr1814693f8f.34.1751454248105; Wed, 02 Jul 2025 04:04:08 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a88c7e72c1sm15617141f8f.1.2025.07.02.04.04.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jul 2025 04:04:07 -0700 (PDT) Message-ID: <819b61fb-ebb0-4ded-a104-01ab133b6a41@redhat.com> Date: Wed, 2 Jul 2025 13:04:05 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 19/29] mm: stop storing migration_ops in page->mapping To: Harry Yoo Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Qi Zheng , Shakeel Butt References: <20250630130011.330477-1-david@redhat.com> <20250630130011.330477-20-david@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02.07.25 12:34, Harry Yoo wrote: > On Mon, Jun 30, 2025 at 03:00:00PM +0200, David Hildenbrand wrote: >> ... instead, look them up statically based on the page type. Maybe in the >> future we want a registration interface? At least for now, it can be >> easily handled using the two page types that actually support page >> migration. >> >> The remaining usage of page->mapping is to flag such pages as actually >> being movable (having movable_ops), which we will change next. >> >> Reviewed-by: Zi Yan >> Signed-off-by: David Hildenbrand >> --- > >> +static const struct movable_operations *page_movable_ops(struct page *page) >> +{ >> + VM_WARN_ON_ONCE_PAGE(!page_has_movable_ops(page), page); >> + >> + /* >> + * If we enable page migration for a page of a certain type by marking >> + * it as movable, the page type must be sticky until the page gets freed >> + * back to the buddy. >> + */ >> +#ifdef CONFIG_BALLOON_COMPACTION >> + if (PageOffline(page)) >> + /* Only balloon compaction sets PageOffline pages movable. */ >> + return &balloon_mops; >> +#endif /* CONFIG_BALLOON_COMPACTION */ >> +#if defined(CONFIG_ZSMALLOC) && defined(CONFIG_COMPACTION) >> + if (PageZsmalloc(page)) >> + return &zsmalloc_mops; >> +#endif /* defined(CONFIG_ZSMALLOC) && defined(CONFIG_COMPACTION) */ > > What happens if: > CONFIG_ZSMALLOC=y > CONFIG_TRANSPARENT_HUGEPAGE=n > CONFIG_COMPACTION=n > CONFIG_MIGRATION=y Pages are never allocated from ZONE_MOVABLE/CMA and are not marked as having movable_ops, so we never end up in this function. See how zsmalloc.c deals with CONFIG_COMPACTION, especially how SetZsPageMovable() is a NOP without it. As a side note, both should probably be moved from COMPACTION to MIGRATION. Although probably in practice, anybody enabling CONFIG_MIGRATION likely also enables CONFIG_COMPACTION. -- Cheers, David / dhildenb