From: Markus Elfring <Markus.Elfring@web.de>
To: Lu Wei <luwei32@huawei.com>, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Alex Williams <alex.williams@ni.com>,
Andrew Lunn <andrew@lunn.ch>,
Dan Carpenter <dan.carpenter@oracle.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Moritz Fischer <mdf@kernel.org>,
Yunjian Wang <wangyunjian@huawei.com>
Subject: Re: [PATCH] net: nixge: fix potential memory leak in nixge_probe()
Date: Wed, 29 Jul 2020 09:49:51 +0200 [thread overview]
Message-ID: <81c16524-29f0-4331-5843-9b2e2c0ee22e@web.de> (raw)
> If some processes in nixge_probe() fail, free_netdev(dev)
> needs to be called to aviod a memory leak.
* Would you like to avoid a typo in this change description?
* An imperative wording can be preferred here, can't it?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=6ba1b005ffc388c2aeaddae20da29e4810dea298#n151
Regards,
Markus
next reply other threads:[~2020-07-29 7:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 7:49 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-07-29 3:50 [PATCH] net: nixge: fix potential memory leak in nixge_probe() Lu Wei
2020-07-30 23:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81c16524-29f0-4331-5843-9b2e2c0ee22e@web.de \
--to=markus.elfring@web.de \
--cc=alex.williams@ni.com \
--cc=andrew@lunn.ch \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luwei32@huawei.com \
--cc=mdf@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wangyunjian@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox