From: Adrian Hunter <adrian.hunter@intel.com>
To: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>
Cc: <ulf.hansson@linaro.org>, <linux-mmc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: sdhci: Quirk for broken command queuing on Intel GLK-based Positivo models
Date: Thu, 26 Jun 2025 17:05:29 +0300 [thread overview]
Message-ID: <81d519f5-caac-4fd8-8491-3580ce1b6060@intel.com> (raw)
In-Reply-To: <20250626112442.9791-1-edson.drosdeck@gmail.com>
On 26/06/2025 14:24, Edson Juliano Drosdeck wrote:
> Disable command queuing on Intel GLK-based Positivo models.
>
> Without this quirk, CQE (Command Queuing Engine) causes instability
> or I/O errors during operation. Disabling it ensures stable
> operation on affected devices.
>
> Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>
Subject would normally begin "mmc: sdhci-pci:" instead of "mmc: sdhci:"
Otherwise:
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Also I guess:
Fixes: bedf9fc01ff1 ("mmc: sdhci: Workaround broken command queuing on Intel GLK")
Cc: stable@vger.kernel.org
> ---
> drivers/mmc/host/sdhci-pci-core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
> index 13a84b9309e0..e3877a1c72a9 100644
> --- a/drivers/mmc/host/sdhci-pci-core.c
> +++ b/drivers/mmc/host/sdhci-pci-core.c
> @@ -913,7 +913,8 @@ static bool glk_broken_cqhci(struct sdhci_pci_slot *slot)
> {
> return slot->chip->pdev->device == PCI_DEVICE_ID_INTEL_GLK_EMMC &&
> (dmi_match(DMI_BIOS_VENDOR, "LENOVO") ||
> - dmi_match(DMI_SYS_VENDOR, "IRBIS"));
> + dmi_match(DMI_SYS_VENDOR, "IRBIS") ||
> + dmi_match(DMI_SYS_VENDOR, "Positivo Tecnologia SA"));
> }
>
> static bool jsl_broken_hs400es(struct sdhci_pci_slot *slot)
next prev parent reply other threads:[~2025-06-26 14:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 11:24 [PATCH] mmc: sdhci: Quirk for broken command queuing on Intel GLK-based Positivo models Edson Juliano Drosdeck
2025-06-26 14:05 ` Adrian Hunter [this message]
2025-07-01 23:07 ` edson drosdeck
2025-07-03 12:19 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81d519f5-caac-4fd8-8491-3580ce1b6060@intel.com \
--to=adrian.hunter@intel.com \
--cc=edson.drosdeck@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox