From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88EBF21B9FF for ; Thu, 29 May 2025 09:21:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748510462; cv=none; b=C7tmMFJ03v6WWsVYNARwYWJmbob0/iZmqvqT6nhnhwGlvxyVNNivKf88Y/TGoF1MLfFrmowRKdMuDd4agOxN12BCMSHa/F0RfzLR0MPV4WWxRb//tAcHmTwe8utmQZ4OkVtR9xIJZrkzPjQmhlFyB9raCusuFyF72+JYCHiuhaE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748510462; c=relaxed/simple; bh=L4s52w8/kLW8XlEfsikn2Ky0fab9wuw9vsM2KIVpWIs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KrHP/p6PKOzzwIGWdgC+o/BSkJbXtQHJgJLCpn601lcMgeEwZ3/HsL1r6lC+/yGsIGS7H1com26JTE6mjx8gOVUokPLLKZn8xzhIC9tFXMdjB3n5K+pGJ4wBo2FoNn6ZrqqtL3g4PJ12c6c0ywJwyYDJm/rN/ybmympk2uaf4eI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gOWJ42jS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gOWJ42jS" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54T0SkSu027806 for ; Thu, 29 May 2025 09:20:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fK2aLxCi/pD0NxBchLLM+RpJQItFN6CcDN585z6c3/M=; b=gOWJ42jSinOMwcFO Mruay/q3M9GdMi2t4wCd/qHJDA4TIewJYssc7M9dOMZaCKCiB3AMN4tGQH9dYYDT NDvleWuF5SX9fXGdxvzegGcjJ49u8dWMNbiPOwViVVNMzEbhAPZyGvi2y/KRjz+Q NaXYpKzG7/9iWQk7Dr/lybMk8vXwYknxJHFYasFaJxrWWgkAbnpHFK1O3LJMp97P Mg6Xq0oWFZeYW5+4zCOGLTDw3E4/pzGITJmZeEfd3Y1Ikwv7dMdUu1QJws2ZvImH aCA3fSoKsXFgk7UXCI351Ew3pP4wamTRPs0AgSOTpZkcI7iQYHz7DA9WRZs2zOIA 9E++Ew== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46w992q8n0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 29 May 2025 09:20:59 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7d097fd7b32so134412785a.2 for ; Thu, 29 May 2025 02:20:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748510458; x=1749115258; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fK2aLxCi/pD0NxBchLLM+RpJQItFN6CcDN585z6c3/M=; b=aV+az6KzH1nHmbxZ/igB6X6u9nCbzja4JJqPKfXABTIMMQ31aT9YIJGYc2jWsT2EmZ 1QD343wv00yhvyIFtoo5e6+PwEtfV036So66t91c+3yde/1PIGUvT1zyYDzPP2SLb6zP weFsRAxA8hRrcpvsJtAipVoYQjt6pvYb0caR7oyJqZTJOE26Rl6ffkrBx6PIu0U0GZZd NOljToU9EyKwRqfN5htOZOIEJQsIbgN7nvN8XgD2+oOCWTEqgjV6KLPt7ydTvPT6115D ymdVbot0pnXT5DuWNJYOJepjBENxXff02yBoIzSJd/2rFrbSIgGd8cmlRqNUEN4wIJfI xZWw== X-Forwarded-Encrypted: i=1; AJvYcCXT/cLdTNL6eZ7AqR8nId+zNi/9w1HI/YGsiCtZLv8Vqhie6O+A4g+mbvIpWGYgiScxVUW6ZI2rR3ezgh8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2ieMr7a2t/QBvdHgjYdO1y0QQqnHDco0cOq0kN47EJaD2LRZ5 Jiiq7xzPgMAx/EZPRLXLXRukmBVyhoWfvoL8HLErXr63WBXONE8PLO1Qi5AVn0T68hwo+QQIA1X jaM1QzRpu/6fLbpQvlFOxjO+CwMtbJDsb2EtilwXBviyKiNdc1qi7E/U6pJ8rQV50SSs= X-Gm-Gg: ASbGncvIRGDKjeB8uKuNYSszNK4d5apmsTr5RU7To9PbdaFMsAK++Kl2j+MozJt3kZ9 HDMxW/8T5vCeklkz3qcMb/PcasOP1T3sFj9aFreyojxXNAweQRnDN0hDghIbFqjXFwLW3ZQFD0r WAT8R92tCiIDin1AyHCcnjvldnHyssJUII36GqYJdQBTZ2uooDcBUpImUFCfFQRwWotjpnjsFUD qr2mANJ0u3zaiRCNmj8Q9jqmtEVTCPVssnwzJmMpo6jA7QChZ98BgkSkDyQFSoCgRZOklyyg/Gi jenS1gaery4LbcG8V54gZcR4OE7/sRITXEdNAA== X-Received: by 2002:a05:620a:29cf:b0:7ce:e89c:7034 with SMTP id af79cd13be357-7ceecc47330mr3414854885a.54.1748510458187; Thu, 29 May 2025 02:20:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFARviQoTt32XuVus+Hg1NVtxvnQWat2/gBG0kwZldF4ALlWhMfHSvxPfbQYwCTS8VMYZNGFQ== X-Received: by 2002:a05:620a:29cf:b0:7ce:e89c:7034 with SMTP id af79cd13be357-7ceecc47330mr3414852185a.54.1748510457805; Thu, 29 May 2025 02:20:57 -0700 (PDT) Received: from [192.168.68.109] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-3a4efe73ee0sm1390768f8f.46.2025.05.29.02.20.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 May 2025 02:20:57 -0700 (PDT) Message-ID: <81e34c57-d2ed-466a-9ab0-8ea9e7ee437f@oss.qualcomm.com> Date: Thu, 29 May 2025 10:20:56 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/6] ASoC: codecs: wcd93xx: Few simplifications of code and extend wcd939x To: Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20250526-b4-asoc-wcd9395-vdd-px-v1-0-64d3cb60313b@linaro.org> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <20250526-b4-asoc-wcd9395-vdd-px-v1-0-64d3cb60313b@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTI5MDA5MCBTYWx0ZWRfX826TOFIwv6jr h/RThYgHS1Ka0ukVxZ7tFodPkbf1riAq5WUAPlaq9rkeYPe18tkvM4i9YnkvbFXoHJvYUIMuRed YXszvXFRNw920jVnvfKX9H10GI+rZpFNfICNHK2yzVyG5cdcxKZQWn5Xfh6p03ESX8JxkCQC5w+ 9tn4kRzLriZQW9Ge82tQ4pWzwotSIquAmn+/ZlHs6lPneDoM41VI7rLNcs9xm+Otqmb+X5mebWr OY0KTk0kfB+KOYDk/6qWsLPze2jzYawynjpsgRY+OB0v/YJSwqGnTleJdNTHoQfn+2IllufRDJA VYq4kAWqmF1s9NApDM3WDv/a79TZWLoST70068TkUJyZG1tLL0ADx7VFNqshRU56H8hMflqlH/q Rw4OiGotCQfUWbtdM5gmKYlO/ioIh4dL4+b9Uqx13v74/s2TVacPw5f72g+dLa7FYcsk6txS X-Authority-Analysis: v=2.4 cv=Fes3xI+6 c=1 sm=1 tr=0 ts=683826fb cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=PGxqiohRGJHFK62Qb5wA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: gvZa4q__XARnrdulUfNZZlxI3r84fv5w X-Proofpoint-ORIG-GUID: gvZa4q__XARnrdulUfNZZlxI3r84fv5w X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-29_04,2025-05-29_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 impostorscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 priorityscore=1501 mlxlogscore=724 spamscore=0 adultscore=0 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505160000 definitions=main-2505290090 On 5/26/25 11:49 AM, Krzysztof Kozlowski wrote: > Make the WCD93xx codec drivers simpler using > devm_regulator_bulk_get_enable() and obtain missing VDD_PX supply on > wcd939x. > > Context depends on fixes: > https://lore.kernel.org/r/20250526-b4-b4-asoc-wcd9395-vdd-px-fixes-v1-0-0b8a2993b7d3@linaro.org > LGTM, thanks for the cleanup. Reviewed-by: Srinivas Kandagatla -Srini > --- > Krzysztof Kozlowski (6): > ASoC: codecs: wcd937x: Simplify with devm_regulator_bulk_get_enable() > ASoC: codecs: wcd938x: Simplify with devm_regulator_bulk_get_enable() > ASoC: codecs: wcd939x: Simplify with devm_regulator_bulk_get_enable() > ASoC: codecs: wcd939x: Simplify return from devm_gpiod_get() error > ASoC: dt-bindings: qcom,wcd939x: Document missing VDD_PX supply > ASoC: codecs: wcd939x: Add VDD_PX supply > > .../devicetree/bindings/sound/qcom,wcd939x.yaml | 3 ++ > sound/soc/codecs/wcd937x.c | 31 +++++---------- > sound/soc/codecs/wcd937x.h | 1 - > sound/soc/codecs/wcd938x.c | 35 +++++------------ > sound/soc/codecs/wcd939x.c | 45 +++++++--------------- > 5 files changed, 34 insertions(+), 81 deletions(-) > --- > base-commit: 3717d2adda1ad07b4ecf3bef144ee489cc1563a1 > change-id: 20250526-b4-asoc-wcd9395-vdd-px-ec173383bd02 > prerequisite-change-id: 20250526-b4-b4-asoc-wcd9395-vdd-px-fixes-0ce64398f9cc:v1 > prerequisite-patch-id: 104000f7254b9cc81be49af9ca584544718e52f1 > prerequisite-patch-id: 230fcd1b712c5a3199e7c9d8250e98e5d55c0a40 > prerequisite-patch-id: ecdbe74955eb7b710f72af1e3cf32ccac52890d5 > > Best regards,