public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chun-Jie Chen <chun-jie.chen@mediatek.com>
To: Chen-Yu Tsai <wenst@chromium.org>,
	Stephen Boyd <sboyd@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Matthias Brugger <matthias.bgg@gmail.com>
Cc: AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	Miles Chen <miles.chen@mediatek.com>, <linux-clk@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 14/31] clk: mediatek: pll: Clean up included headers
Date: Tue, 15 Feb 2022 14:34:06 +0800	[thread overview]
Message-ID: <81e8440bea87ef2b03b04ca135da4df0fdaef2de.camel@mediatek.com> (raw)
In-Reply-To: <20220208124034.414635-15-wenst@chromium.org>

On Tue, 2022-02-08 at 20:40 +0800, Chen-Yu Tsai wrote:
> Some included headers aren't actually used anywhere, while other
> headers
> with the declaration of functions and structures aren't directly
> included.
> 
> Get rid of the unused ones, and add the ones that should be included
> directly.
> 
> Also, copy the MHZ macro from clk-mtk.h, and drop clk-mtk.h from the
> included headers.
> 
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> Reviewed-by: Miles Chen <miles.chen@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>

Reviewed-by: Chun-Jie Chen <chun-jie.chen@mediatek.com>
> ---
>  drivers/clk/mediatek/clk-pll.c | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/clk/mediatek/clk-pll.c
> b/drivers/clk/mediatek/clk-pll.c
> index b54e33b75d4e..8439d37e354d 100644
> --- a/drivers/clk/mediatek/clk-pll.c
> +++ b/drivers/clk/mediatek/clk-pll.c
> @@ -4,17 +4,19 @@
>   * Author: James Liao <jamesjj.liao@mediatek.com>
>   */
>  
> -#include <linux/of.h>
> -#include <linux/of_address.h>
> +#include <linux/clk-provider.h>
> +#include <linux/container_of.h>
> +#include <linux/delay.h>
> +#include <linux/err.h>
>  #include <linux/io.h>
>  #include <linux/module.h>
> +#include <linux/of_address.h>
>  #include <linux/slab.h>
> -#include <linux/clkdev.h>
> -#include <linux/delay.h>
>  
> -#include "clk-mtk.h"
>  #include "clk-pll.h"
>  
> +#define MHZ			(1000 * 1000)
> +
>  #define REG_CON0		0
>  #define REG_CON1		4
>  


  reply	other threads:[~2022-02-15  6:34 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-08 12:40 [PATCH v3 00/31] clk: mediatek: Cleanups and Improvements - Part 1 Chen-Yu Tsai
2022-02-08 12:40 ` [PATCH v3 01/31] clk: mediatek: Use %pe to print errors Chen-Yu Tsai
2022-02-15  6:06   ` Chun-Jie Chen
2022-02-17 20:20   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 02/31] clk: mediatek: gate: Consolidate gate type clk related code Chen-Yu Tsai
2022-02-15  6:20   ` Chun-Jie Chen
2022-02-17 20:20   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 03/31] clk: mediatek: gate: Internalize clk implementation Chen-Yu Tsai
2022-02-15  6:22   ` Chun-Jie Chen
2022-02-17 20:20   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 04/31] clk: mediatek: gate: Implement unregister API Chen-Yu Tsai
2022-02-15  6:23   ` Chun-Jie Chen
2022-02-17 20:21   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 05/31] clk: mediatek: gate: Clean up included headers Chen-Yu Tsai
2022-02-15  6:24   ` Chun-Jie Chen
2022-02-17 20:21   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 06/31] clk: mediatek: cpumux: Implement unregister API Chen-Yu Tsai
2022-02-15  6:25   ` Chun-Jie Chen
2022-02-17 20:21   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 07/31] clk: mediatek: cpumux: Internalize struct mtk_clk_cpumux Chen-Yu Tsai
2022-02-15  6:25   ` Chun-Jie Chen
2022-02-17 20:21   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 08/31] clk: mediatek: cpumux: Clean up included headers Chen-Yu Tsai
2022-02-15  6:26   ` Chun-Jie Chen
2022-02-17 20:21   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 09/31] clk: mediatek: mux: Implement unregister API Chen-Yu Tsai
2022-02-15  6:30   ` Chun-Jie Chen
2022-02-17 20:24   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 10/31] clk: mediatek: mux: Internalize struct mtk_clk_mux Chen-Yu Tsai
2022-02-15  6:30   ` Chun-Jie Chen
2022-02-17 20:24   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 11/31] clk: mediatek: mux: Clean up included headers Chen-Yu Tsai
2022-02-15  6:31   ` Chun-Jie Chen
2022-02-17 20:25   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 12/31] clk: mediatek: pll: Split definitions into separate header file Chen-Yu Tsai
2022-02-15  6:32   ` Chun-Jie Chen
2022-02-17 20:25   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 13/31] clk: mediatek: pll: Implement unregister API Chen-Yu Tsai
2022-02-15  6:33   ` Chun-Jie Chen
2022-02-17 20:25   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 14/31] clk: mediatek: pll: Clean up included headers Chen-Yu Tsai
2022-02-15  6:34   ` Chun-Jie Chen [this message]
2022-02-17 20:25   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 15/31] clk: mediatek: Implement mtk_clk_unregister_fixed_clks() API Chen-Yu Tsai
2022-02-15  6:35   ` Chun-Jie Chen
2022-02-17 20:25   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 16/31] clk: mediatek: Implement mtk_clk_unregister_factors() API Chen-Yu Tsai
2022-02-15  6:36   ` Chun-Jie Chen
2022-02-17 20:26   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 17/31] clk: mediatek: Implement mtk_clk_unregister_divider_clks() API Chen-Yu Tsai
2022-02-15  6:36   ` Chun-Jie Chen
2022-02-17 20:26   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 18/31] clk: mediatek: Implement mtk_clk_unregister_composites() API Chen-Yu Tsai
2022-02-15  6:37   ` Chun-Jie Chen
2022-02-17 20:26   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 19/31] clk: mediatek: Add mtk_clk_simple_remove() Chen-Yu Tsai
2022-02-15  6:37   ` Chun-Jie Chen
2022-02-17 20:26   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 20/31] clk: mediatek: mtk: Clean up included headers Chen-Yu Tsai
2022-02-15  6:57   ` Chun-Jie Chen
2022-02-17 20:26   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 21/31] clk: mediatek: cpumux: Implement error handling in register API Chen-Yu Tsai
2022-02-15  7:00   ` Chun-Jie Chen
2022-02-17 20:27   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 22/31] clk: mediatek: gate: " Chen-Yu Tsai
2022-02-15  7:01   ` Chun-Jie Chen
2022-02-17 20:27   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 23/31] clk: mediatek: mux: Reverse check for existing clk to reduce nesting level Chen-Yu Tsai
2022-02-15  7:04   ` Chun-Jie Chen
2022-02-17 20:27   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 24/31] clk: mediatek: mux: Implement error handling in register API Chen-Yu Tsai
2022-02-15  7:05   ` Chun-Jie Chen
2022-02-17 20:27   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 25/31] clk: mediatek: pll: " Chen-Yu Tsai
2022-02-15  7:05   ` Chun-Jie Chen
2022-02-17 20:28   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 26/31] clk: mediatek: mtk: Implement error handling in register APIs Chen-Yu Tsai
2022-02-15  7:10   ` Chun-Jie Chen
2022-02-17 20:28   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 27/31] clk: mediatek: Unregister clks in mtk_clk_simple_probe() error path Chen-Yu Tsai
2022-02-15  7:11   ` Chun-Jie Chen
2022-02-17 20:29   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 28/31] clk: mediatek: mt8195: Hook up mtk_clk_simple_remove() Chen-Yu Tsai
2022-02-08 13:23   ` AngeloGioacchino Del Regno
2022-02-15  7:12   ` Chun-Jie Chen
2022-02-17 20:29   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 29/31] clk: mediatek: mt8195: Implement error handling in probe functions Chen-Yu Tsai
2022-02-08 13:23   ` AngeloGioacchino Del Regno
2022-02-17 20:29   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 30/31] clk: mediatek: mt8195: Implement remove functions Chen-Yu Tsai
2022-02-08 13:23   ` AngeloGioacchino Del Regno
2022-02-17 20:29   ` Stephen Boyd
2022-02-08 12:40 ` [PATCH v3 31/31] clk: mediatek: Warn if clk IDs are duplicated Chen-Yu Tsai
2022-02-17 20:29   ` Stephen Boyd
2022-02-08 19:32 ` [PATCH v3 00/31] clk: mediatek: Cleanups and Improvements - Part 1 Boris Lysov
2022-02-09  3:13   ` Chen-Yu Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81e8440bea87ef2b03b04ca135da4df0fdaef2de.camel@mediatek.com \
    --to=chun-jie.chen@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=miles.chen@mediatek.com \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=wenst@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox