* [PATCH] Remove unneeded #ifdef kernel from ppc unaligned.h
@ 2004-08-09 5:16 GOTO Masanori
2004-08-09 8:07 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 4+ messages in thread
From: GOTO Masanori @ 2004-08-09 5:16 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras; +Cc: linux-kernel, gotom
This patch removes unneeded #ifdef __KERNEL__ from ppc unaligned.h.
There's no reason to enclose __KERNEL__, similar to other
architectures. It also fixes the compilation failure building
userland helper application reiserfsprogs on ppc which includes
asm/unaligned.h.
Signed-off-by: GOTO Masanori <gotom@debian.or.jp>
--- include/asm-ppc/unaligned.h 2003-12-15 22:57:40.000000000 +0900
+++ include/asm-ppc/unaligned.h.new 2004-08-09 12:17:16.000000000 +0900
@@ -1,4 +1,3 @@
-#ifdef __KERNEL__
#ifndef __PPC_UNALIGNED_H
#define __PPC_UNALIGNED_H
@@ -15,4 +14,3 @@
#define put_unaligned(val, ptr) ((void)( *(ptr) = (val) ))
#endif
-#endif /* __KERNEL__ */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Remove unneeded #ifdef kernel from ppc unaligned.h
2004-08-09 5:16 [PATCH] Remove unneeded #ifdef kernel from ppc unaligned.h GOTO Masanori
@ 2004-08-09 8:07 ` Benjamin Herrenschmidt
2004-08-09 8:16 ` GOTO Masanori
0 siblings, 1 reply; 4+ messages in thread
From: Benjamin Herrenschmidt @ 2004-08-09 8:07 UTC (permalink / raw)
To: GOTO Masanori; +Cc: Paul Mackerras, Linux Kernel list
On Mon, 2004-08-09 at 15:16, GOTO Masanori wrote:
> This patch removes unneeded #ifdef __KERNEL__ from ppc unaligned.h.
> There's no reason to enclose __KERNEL__, similar to other
> architectures. It also fixes the compilation failure building
> userland helper application reiserfsprogs on ppc which includes
> asm/unaligned.h.
Well, userland isn't supposed to use those ...
Ben.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Remove unneeded #ifdef kernel from ppc unaligned.h
2004-08-09 8:07 ` Benjamin Herrenschmidt
@ 2004-08-09 8:16 ` GOTO Masanori
2004-08-09 22:37 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 4+ messages in thread
From: GOTO Masanori @ 2004-08-09 8:16 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: GOTO Masanori, Paul Mackerras, Linux Kernel list
At Mon, 09 Aug 2004 18:07:45 +1000,
Benjamin Herrenschmidt wrote:
> On Mon, 2004-08-09 at 15:16, GOTO Masanori wrote:
> > This patch removes unneeded #ifdef __KERNEL__ from ppc unaligned.h.
> > There's no reason to enclose __KERNEL__, similar to other
> > architectures. It also fixes the compilation failure building
> > userland helper application reiserfsprogs on ppc which includes
> > asm/unaligned.h.
>
> Well, userland isn't supposed to use those ...
I know. It's just side effect. But there's no reason to enclose
#ifdef __KERNEL__.
Regards,
-- gotom
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Remove unneeded #ifdef kernel from ppc unaligned.h
2004-08-09 8:16 ` GOTO Masanori
@ 2004-08-09 22:37 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 4+ messages in thread
From: Benjamin Herrenschmidt @ 2004-08-09 22:37 UTC (permalink / raw)
To: GOTO Masanori; +Cc: Paul Mackerras, Linux Kernel list
On Mon, 2004-08-09 at 18:16, GOTO Masanori wrote:
> At Mon, 09 Aug 2004 18:07:45 +1000,
> Benjamin Herrenschmidt wrote:
> > On Mon, 2004-08-09 at 15:16, GOTO Masanori wrote:
> > > This patch removes unneeded #ifdef __KERNEL__ from ppc unaligned.h.
> > > There's no reason to enclose __KERNEL__, similar to other
> > > architectures. It also fixes the compilation failure building
> > > userland helper application reiserfsprogs on ppc which includes
> > > asm/unaligned.h.
> >
> > Well, userland isn't supposed to use those ...
>
> I know. It's just side effect. But there's no reason to enclose
> #ifdef __KERNEL__.
Hrm... I'd say there is no reason not to enclose it in it, but I'll
let Paul make a final decision here.
Ben.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-08-09 22:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-08-09 5:16 [PATCH] Remove unneeded #ifdef kernel from ppc unaligned.h GOTO Masanori
2004-08-09 8:07 ` Benjamin Herrenschmidt
2004-08-09 8:16 ` GOTO Masanori
2004-08-09 22:37 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox