From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F766279324 for ; Tue, 2 Dec 2025 06:46:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764658011; cv=none; b=HSxDfCv/JiWQhSoQGv+WqxVUW8E0dnE+rDlVHtf3sgQeX96qpCaWD7NTKmDVlRIdy0LoQT3AIcoL8mbg9qdLiZfnC0KUFrkRL8gssJYPMfoSiMLJ8dOf/Lc8php9tMwgVPmYDFOtd3YKmQbYksm3cb6/ROTIOOMEZJNLEYg9/QI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764658011; c=relaxed/simple; bh=HBRCs1AamNdIJF/9dI73CjNFCUcBUeRCCzdf2pPAELE=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=WSxJn2oAtBPgiV3ePMvCAaWATawmG+ygOz6l5zNPRMv8ILbArIWqoo+qCIfkBYgOk3gud8oWsT2gtZOZSzjju/BnD9UenfXg9lb9avanteSUr0D0nzMuHnDB4pAyoe/Su8pXGgxz1Pjzs757yxqhxJCK4bA+Xbq5ZTS/hIJEX5M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Tm1x6u/a; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=It+dzifX; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Tm1x6u/a"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="It+dzifX" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B26cEI71146909 for ; Tue, 2 Dec 2025 06:46:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= K4hL37ryfKZooua5z1CIMJEWGLQg5OaQgwxCnhTYPAQ=; b=Tm1x6u/aa6w4lcDg 9h0ogcojFhU5dCkdlzetBnZukGQtZGwOu5J7sVsDBCunaUBREyVzNb9qrOxqmCMG W34974+XqzaiyWZ3N8QcPK6JzgVOkFjq3J1CDCxb47hmf77wmQUtqvvg6h/Q9GQf 57JN2Kb+aAI8CUD5hP097QBAnA488r8ykQR1pYJhDBzL9hh47MJN5bYNlvqyWqmR nhQbqdHXFf1unmHFxgGrWZkSmS5FbcTKNzJHGDnzrW3zadNy79m/axS7YJeEGe5Z BgINIHr7vzK29cqiAvISKzY0f2Zy2fwhikao4BhDZqzZGAXsdfbTTC+A5fb41TKZ BVLkPg== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4asj5e9j58-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 02 Dec 2025 06:46:49 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-7b82c2c2ca2so7854102b3a.1 for ; Mon, 01 Dec 2025 22:46:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764658009; x=1765262809; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=K4hL37ryfKZooua5z1CIMJEWGLQg5OaQgwxCnhTYPAQ=; b=It+dzifXmUWnxFa1GAtdvcI8G8l0K/Cfrwtj7OPDXvBtuGGtHEnicXIAZy+6LCp6C0 oPitYusK6SEmmXhAK3F0G4Bhhkt3hJq4qqBLSnJ6ZWRoOfZyAb+SpCnNEm/FAXjxNo8Z VhKJRZBNNQ5PH9okG18NNIFyTrbShTipmXlOKylfTHW31aWi06CjtbWv9GKElbQVo1Vo vXEY33waInM7qwNWL/9yzzlE7CTaIKSQDuG6gKzuXoXmXWtSM1mkWRCtf3WdqjAyUZ3B a64zJsiNH1YF7phok7VSCxV8gvDDIZ9MuF2AGvmvvdH71TdcqcIRT5PDxHMZcMQaJLbp cV8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764658009; x=1765262809; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=K4hL37ryfKZooua5z1CIMJEWGLQg5OaQgwxCnhTYPAQ=; b=ViI0NrdggiDV61rQPlgdOA2XUJomwp+Vw/51jNeekHb/spt5bw0jxhiXPI1uIv94Mh 05CLTL/KofqTTKrJMN4XobCmzGomAFJEB0emADHCm7wvFPbhUFTadWk2zc5Z6TilpQKX XUuWdAlWUE/pQwkCmzWRtNnbe5FLvzdXvPmzLMtvOE9gNW8TT9g2sPUtFLhRWpqB8iF4 KdrvKfPuCjNsZN+Hd12MxWGG2YrTzPOIP/HJkW3mPI0pKvvse8BDK47yIqGdd79fjgv4 ZY1XcnWsNSPgSk317njhwTUDPwf/FPgRYckGczuISEQBmQcuVyJvxm71xmTouvGHAp7I ldhA== X-Forwarded-Encrypted: i=1; AJvYcCVAYgoKiHqP3BTkRnKlrOkdsX5gWdStouQX5uAjLauvN6mJkTEP11Omw6CbznKw55iWWTKO3sPbu3T0k4g=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+XpB0w1W1bXDlCOzIOFjSbWG4jQxnIzbCEiONnkBOUntVj+Q8 +eljvM5VF18uqrkSp8S7Dc900Grc69mQjo1kcfCrknCg97bZ3maWFb9AVS4trpoICSVLVt277+f Zp7FgjCY83CBH9HGOcSsu03vT9/7RF9K+AJS8qyZAEvcDwiSw/PZNm/lCVzKdtbxcXUA= X-Gm-Gg: ASbGnct257DZ1VGr9KdEdrOuhI1xsKEbdtNQ6boFIUxUuOSUwu1BNEMrym2jP5gbXpM cOnvjNO2dVQ0Jb4oVgZlLmmBCvsc0EWS3TCPgjj+BGvyG67rWRxtsiNFp3/jnLOLRGU7KmplE91 3UwOpFoLsFlrxuvSOWnvWwbUU3UAf+M1ZCO+yb9/BlNcD1/26aFngXewj71zOSi4Jr6qRORNXl+ GQxbAkVNV8MQO4sPj+kPfV4KPHeCnbIblc/F6KUGE6ATIg8riHII+EihimgqLYaxxUAy3olRoix 691RxPLryD/kNnAUx4xDDoNVjvfvUF8TCmPBn9hVfbBFelEgj6ioaQQfHXmnTT/bQeRq6pwZj8C +2xRn7ZqCk5/MeFBJbFodufpP17ZLoKLmetZLV5ah8kp51WYzyQ+unNgrVb1pwu9UxYQnlbEQQL EO/qc= X-Received: by 2002:a05:6a00:2d88:b0:7b9:ef46:ec70 with SMTP id d2e1a72fcca58-7c58e50c16emr36985255b3a.23.1764658008624; Mon, 01 Dec 2025 22:46:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IEBuB5Wxg4y4+7oDbzkOmJUFvZwkaOI7FxujqFNERmdby/NSN70EoNA8ohS8Y3cBB4eywIjsA== X-Received: by 2002:a05:6a00:2d88:b0:7b9:ef46:ec70 with SMTP id d2e1a72fcca58-7c58e50c16emr36985231b3a.23.1764658008157; Mon, 01 Dec 2025 22:46:48 -0800 (PST) Received: from [10.249.18.58] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7d15f17877dsm15596931b3a.52.2025.12.01.22.46.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Dec 2025 22:46:47 -0800 (PST) Message-ID: <820ea981-2fa4-48be-9bee-8936804bfd7a@oss.qualcomm.com> Date: Tue, 2 Dec 2025 14:46:43 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: wangao.wang@oss.qualcomm.com, quic_qiweil@quicinc.com, Renjiang Han , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] media: qcom: iris: Add B frames support for encoder To: Bryan O'Donoghue , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Mauro Carvalho Chehab References: <20251127-batch2_iris_encoder_enhancements-v1-0-5ea78e2de2ae@oss.qualcomm.com> <0RpTUQpD7Q78IUmEj6-bUEv88YSaTJgDDRCijfUjARogqOhmeEA_EwzpNqYcEPUgHGaC7PfHqP51IBfGQCilfw==@protonmail.internalid> <20251127-batch2_iris_encoder_enhancements-v1-3-5ea78e2de2ae@oss.qualcomm.com> Content-Language: en-US From: Wangao Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: DhkFEbr0Z2Fbq6V0KN3AJs6xbL7BK-LW X-Authority-Analysis: v=2.4 cv=GMsF0+NK c=1 sm=1 tr=0 ts=692e8b59 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=k83K-hkaxLq1U7NWHuEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=7jBqKnKQzRwA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjAyMDA1MiBTYWx0ZWRfX/6QRmjwBbTi9 2MRFb6s+UWOGRsRngVzLoQEtaa2rXqTIu7B1g1VTUkwKfJtOuhy3UOuHheo2wdOog/669xOa0ri 3OxrzeLpQ0fcNfVFZjIxryk8t413T6TpCIXiC2frhTdtgKQ+ggyoQfJn0BH6TkQCh3mFwIXtOfv MNLLHjNhuko+C2bh05+9HN71oz8UD7AIOuBEoudBwUPOOxgN/qO2wTKaCj8STAPczklPpAcOdSv 0qAD55zjc8+XcqAOAxjv9EcPnj286g6QEFKrzupK3hJKirn7+0pd+8GaboeBq9S4Di8fxeSgV73 AOPvzo7Qk6cMrdtne4jEpFk0oBHXf99fHtHVVFcaj8Xc7q1rXwAug8y/iI+7MM3LZW3huOxgIyb 28IYXDJ5HLj3p3x1/RJhwA6RCICNGg== X-Proofpoint-ORIG-GUID: DhkFEbr0Z2Fbq6V0KN3AJs6xbL7BK-LW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-28_08,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 malwarescore=0 impostorscore=0 suspectscore=0 clxscore=1015 adultscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512020052 On 2025/11/27 18:43, Bryan O'Donoghue wrote: > On 27/11/2025 07:44, Wangao Wang wrote: >> +    intra_period.pframes = (gop_size - 1) / (b_frame + 1); >> +    intra_period.bframes = b_frame; > > Why do you need to set pframes when setting bframes ? > > --- > bod intra_period represents the length of a GOP, which includes both P-frames and B-frames. The counts of P-frames and B-frames within a GOP must be communicated to the firmware. -- Best Regards, Wangao