From: Stanislav Zaikin <zstaseg@gmail.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-kernel@vger.kernel.org, val@packett.cool
Subject: Re: [PATCH v5 2/2] arm64: dts: qcom: Add Xiaomi 12 Lite 5G (taoyao) DTS
Date: Tue, 12 May 2026 09:59:59 +0200 [thread overview]
Message-ID: <8216541f-3615-473f-b9de-139e6d32a7f1@gmail.com> (raw)
In-Reply-To: <pxldv7v6iymoa7oyg5xs5d76atl7fliol4oty3urudvnkoaynj@4xhovegebszz>
On 4/19/26 1:47 AM, Dmitry Baryshkov wrote:
> On Fri, Apr 17, 2026 at 10:47:49AM +0200, Stanislav Zaikin wrote:
>> Xiaomi 12 Lite 5G is a handset released in 2022
>>
>> This commit has the following features working:
>> - Display (with simple fb)
>> - Touchscreen
>> - UFS
>> - Power and volume buttons
>> - Pinctrl
>> - RPM Regulators
>> - Remoteprocs - wifi, bluetooth
>> - USB (Device Mode)
>>
>> Signed-off-by: Stanislav Zaikin <zstaseg@gmail.com>
>> ---
>> arch/arm64/boot/dts/qcom/Makefile | 1 +
>> .../boot/dts/qcom/sm7325-xiaomi-taoyao.dts | 907 ++++++++++++++++++
>> 2 files changed, 908 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/qcom/sm7325-xiaomi-taoyao.dts
>>
>> +
>> +&ipa {
>> + qcom,gsi-loader = "self";
>> + memory-region = <&ipa_fw_mem>;
>
> Could you please move these properties to SoC dtsi (as a separate
> commit).
>
Sure will do in v6.
>> + firmware-name = "qcom/sm7325/xiaomi/taoyao/ipa_fws.mbn";
>> +
>> + status = "okay";
>> +};
>> +
>> +
>> +&tlmm {
>> + gpio-reserved-ranges = <48 4>, <56 4>;
>
> Could you please add a comment why they are reserved? I _assume_ that 48
> is NFC SE and 56 is fingerprint reader
I can add a comment like this (or you can suggest different wording):
/*
* 48-51: presumably NFC SE
* 56-59: presumably fingerprint reader
*/
If that works, I will add in v6.
Thanks for the review,
Best regards,
Stanislav
next parent reply other threads:[~2026-05-12 8:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260417084749.253242-1-zstaseg@gmail.com>
[not found] ` <20260417084749.253242-3-zstaseg@gmail.com>
[not found] ` <pxldv7v6iymoa7oyg5xs5d76atl7fliol4oty3urudvnkoaynj@4xhovegebszz>
2026-05-12 7:59 ` Stanislav Zaikin [this message]
2026-05-13 14:34 ` [PATCH v5 2/2] arm64: dts: qcom: Add Xiaomi 12 Lite 5G (taoyao) DTS Dmitry Baryshkov
[not found] ` <73cd6f96-07ea-46c3-8f6f-1cc8086a28fe@oss.qualcomm.com>
2026-05-12 8:03 ` Stanislav Zaikin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8216541f-3615-473f-b9de-139e6d32a7f1@gmail.com \
--to=zstaseg@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=val@packett.cool \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox