From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpcmd0871.aruba.it (smtpcmd0871.aruba.it [62.149.156.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38B7E331EA7 for ; Tue, 30 Jun 2026 12:42:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.149.156.71 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782823373; cv=none; b=sKorDq9UA2Y+LfWNmJV1S0L/k/dCtxdSimbUC9lVgcPcNY2y4MCp5cOoj7NHItQpvrFjTkx5eDS7H8uVUikmo4p3OOIFLyrM6oikpIizTEr50GEH8rT1uDVjByhmqxcSkH3Gt07rq0YDcXQPLcuhsJMstr+OQ9MelTYMf9Atpyo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782823373; c=relaxed/simple; bh=1HtyX/e67qrYwhp6iSiJ3rddaRu8/j9pwC394GbTxsk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NURp9iOSR/DsFbPoS9l9ljSDan2I4TM8exmrBujbqsXRzB7VPGTkBXckMOZZNO/Hn9lFva6L5ptbuceK4TK31/nSdoCXil2vGT1GTfTpBbywKqwCDn9yt80c7JKK1abrO13OpZPYDkOCP8EpA+BhB/vlAJ5NkJI0Jmf4qGbgxSM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=enneenne.com; spf=pass smtp.mailfrom=enneenne.com; dkim=pass (2048-bit key) header.d=aruba.it header.i=@aruba.it header.b=F0gL3Umg; arc=none smtp.client-ip=62.149.156.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=enneenne.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=enneenne.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=aruba.it header.i=@aruba.it header.b="F0gL3Umg" Received: from [192.168.0.186] ([101.57.122.26]) by Aruba SMTP with ESMTPSA id eXkawrGH9ZCONeXkbwE3t0; Tue, 30 Jun 2026 14:39:41 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aruba.it; s=a1; t=1782823181; bh=1HtyX/e67qrYwhp6iSiJ3rddaRu8/j9pwC394GbTxsk=; h=Date:MIME-Version:Subject:To:From:Content-Type; b=F0gL3Umg31GVqFfgSvWZ/4u4XyEnjnAqfo3MVnbq7NzwYMI0V7hMGTgIYxp1kKAhA FyuUnNHYg9gFNAWj9/V4cKh92E6a4CeS+KF4pyc3bVt5hodpr0vPOHBkuPk/u7KnEP OtgkuEw/XAj29PsRaCKIdwQxIKBW6IUHRnkyuloF29h1tQcEfeuSCzKzJ0CWeorVGT krjzq6DNS1xUHJVusYLQR3VlIIL+Q8altRqnjFsJCvXjN01HR98JEKPt62mZbDmyuO B5ikbGhfHLud0lH4yDlAcn1AN8okPBNiuyBNHACcAfzjLsfcs+Cdim1wR+RuyB3Rt3 QJ6BAmcfrUu0g== Message-ID: <82220d9e-219a-4ea3-bc4f-a433d6971ee7@enneenne.com> Date: Tue, 30 Jun 2026 14:39:40 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 1/3] pps: Add PPS_SETCLOCK ioctl Content-Language: en-US To: Gerik Kubiak Cc: richardcochran@gmail.com, linux-kernel@vger.kernel.org References: <20260627205028.105252-1-gerikkub@gmail.com> <20260627205028.105252-2-gerikkub@gmail.com> From: Rodolfo Giometti In-Reply-To: <20260627205028.105252-2-gerikkub@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfID41+FVFYT0BQeKxaSjalvGMvq2ZQ5U5cW/rbK2Ccx7IoGcAEprnk92jdGSvr6za+e35BqF/BX1kCVJkY8hE5JCFDhZVyKyfin8NknJPAFZmfFJ9mWm 6GevAhVu+W4TYCt2pchbcLYQE8lIe9JtcUNhO6/ueHFWp8uevUyz5d5pRN+jpnufSkWyIaQ6a7zGnPAm0zturHYyUbYr3/r1i1yJjmWAwRyXpDGKtTpsLOwZ smyWYDcRYPAUfdwV3WYi9inqzJE6cW1NbuKXc/5Lw1U= On 27/06/2026 22:50, Gerik Kubiak wrote: > Add the PPS_SETCLOCK ioctl to the pps driver and an associated > pps_kclock_source structure used as an arugment in the ioctl. This ioctl > allows userspace to specify the clock used in timestamping PPS events. > > Adds a pps_kclock_source structure for this ioctl. It contains one value, > clock_id, which holds the requested clock source for subsequent PPS events. > > Signed-off-by: Gerik Kubiak > --- > include/uapi/linux/pps.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/uapi/linux/pps.h b/include/uapi/linux/pps.h > index 009ebcd8ced5..db233511c6ef 100644 > --- a/include/uapi/linux/pps.h > +++ b/include/uapi/linux/pps.h > @@ -87,6 +87,10 @@ struct pps_kparams { > struct pps_ktime clear_off_tu; /* offset compensation for clear */ > }; > > +struct pps_kclock_source { > + __u32 clock_id; /* System clock id */ > +}; > + > /* > * 3.3 Mode bit definitions > */ > @@ -140,6 +144,7 @@ struct pps_bind_args { > int consumer; /* selected kernel consumer */ > }; > > + > #include Don't add not needed empty lines. > > #define PPS_GETPARAMS _IOR('p', 0xa1, struct pps_kparams *) > @@ -147,5 +152,6 @@ struct pps_bind_args { > #define PPS_GETCAP _IOR('p', 0xa3, int *) > #define PPS_FETCH _IOWR('p', 0xa4, struct pps_fdata *) > #define PPS_KC_BIND _IOW('p', 0xa5, struct pps_bind_args *) > +#define PPS_SETCLOCK _IOW('p', 0xa6, struct pps_clock_source *) Why not merge this patch with patch 3? > > #endif /* _PPS_H_ */ Rodolfo -- GNU/Linux Solutions e-mail: giometti@enneenne.com Linux Device Driver giometti@linux.it Embedded Systems phone: +39 349 2432127 UNIX programming