Re: [PATCHv4 9/9] ASoC: dt-bindings: fsl-asoc-card: add compatible for generic codec

Elinor Montmasson
2024-05-17T09:05:48Z

From: "Mark Brown" <broonie@kernel.org>
Sent: Thursday, 16 May, 2024 14:11:11
> On Wed, May 15, 2024 at 03:54:11PM +0200, Elinor Montmasson wrote:
>
>> Add documentation about new dts bindings following new support
>> for compatible "fsl,imx-audio-generic".
>
>> audio-codec:
>> - $ref: /schemas/types.yaml#/definitions/phandle
>> - description: The phandle of an audio codec
>> + $ref: /schemas/types.yaml#/definitions/phandle-array
>> + description: |
>> + The phandle of an audio codec.
>> + If using the "fsl,imx-audio-generic" compatible, give instead a pair of
>> + phandles with the spdif_transmitter first (driver SPDIF DIT) and the
>> + spdif_receiver second (driver SPDIF DIR).
>> + items:
>> + maxItems: 1
>
> This description (and the code) don't feel like they're actually generic
> - they're clearly specific to the bidrectional S/PDIF case. I'd expect
> something called -generic to cope with single CODECs as well as double,
> and not to have any constraints on what those are.

I proposed, in an reply of the v3 patch series to Krzysztof Kozlowski,
the compatible "fsl,imx-audio-no-codec" instead of "generic".
Krzysztof thought it was too generic, but it would convey more clearly
that it is for cases without codec driver.
Would this other compatible string be more appropriate ?

Best regards,
Elinor Montmasson