Re: [PATCH 0/8] Add Axiado AX3000 eMMC Host Controller Support

Krzysztof Kozlowski
2026-01-12T08:33:52Z

On 09/01/2026 10:48, Tzu-Hao Wei wrote:
> On 12/23/2025 10:33 PM, Krzysztof Kozlowski wrote:
>>
>> You completely disorganized the patch.. dts is mixed all over driver
>> code, you combined two or three completely independent subsystems into
>> one.
>>
>> Read submitting patches in DT dir to understand how DTS must be sent.
>>
>>
>> Best regards,
>> Krzysztof
>>
> Hi Krzysztof,
>
> Appreciate your review comments. We reorganized the patch series per your review comments, separating the DTS changes and applying the driver code changes to the respective subsystems as following

Please wrap your emails correctly.

> https://lore.kernel.org/all/20260109-axiado-ax3000-add-emmc-phy-driver-support-v1-0-dd43459dbfea@axiado.com/

You sent this as v1, which I noticed only now. If I knew you ignored my
feedback, I would not care to review again... Lesson for me.

> https://lore.kernel.org/all/20260109-axiado-ax3000-add-emmc-host-driver-support-v2-0-934f1a61f7c0@axiado.com/
>
> We will also sync up internally and tighten our review process to ensure this kind of mistake does not happen again in future submissions.

Best regards,
Krzysztof