From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C035EC433DF for ; Tue, 19 May 2020 09:04:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A053E2088E for ; Tue, 19 May 2020 09:04:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="t+kUlADo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728590AbgESJET (ORCPT ); Tue, 19 May 2020 05:04:19 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:61008 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726333AbgESJEQ (ORCPT ); Tue, 19 May 2020 05:04:16 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1589879056; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=krynLA3PVnStDQ90BA4lcITyrT/iSvbyv+EPo/hP2Ao=; b=t+kUlADoFqk2nX/65Phd+o0hNVTBRhvuKfAjtjTLfuNRsmtq7Rk14fak0LV6VlMFP5X0/b0M ULTW9WGl2W53kfWpSWo310omNVmNOUKn7foXmQsJnua2JpRkevcxUYDhZmEJCl52/B2+4hxL 1puGTvX3AW7wbWwE+2mHqPXKb9E= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5ec3a104.7f793d152148-smtp-out-n03; Tue, 19 May 2020 09:04:04 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id BBFCAC433F2; Tue, 19 May 2020 09:04:04 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id 14B85C433D2; Tue, 19 May 2020 09:04:03 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 19 May 2020 14:34:03 +0530 From: Sai Prakash Ranjan To: Mike Leach , Suzuki K Poulose , Mathieu Poirier Cc: Stephen Boyd , Linux Kernel Mailing List , linux-arm-msm@vger.kernel.org, linux-arm-kernel , Russell King Subject: Re: [PATCH] coresight: dynamic-replicator: Fix handling of multiple connections In-Reply-To: <4bd741e342f8e2743197ed6105dacffa@codeaurora.org> References: <20200426143725.18116-1-saiprakash.ranjan@codeaurora.org> <84918e7d-c933-3fa1-a61e-0615d4b3cf2c@arm.com> <668ea1283a6dd6b34e701972f6f71034@codeaurora.org> <5b0f5d77c4eec22d8048bb0ffa078345@codeaurora.org> <759d47de-2101-39cf-2f1c-cfefebebd548@arm.com> <7d343e96cf0701d91152fd14c2fdec42@codeaurora.org> <47f6d51bfad0a0bf1553e101e6a2c8c9@codeaurora.org> <37b3749e-2363-0877-c318-9c334a5d1881@arm.com> <364049a30dc9d242ec611bf27a16a6c9@codeaurora.org> <5a76926a6532d3f91cca169d474ba98e@codeaurora.org> <4bd741e342f8e2743197ed6105dacffa@codeaurora.org> Message-ID: <825b922dab9821fa46f321d600648e10@codeaurora.org> X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mike, Suzuki, On 2020-05-16 15:34, Sai Prakash Ranjan wrote: > Hi Mike, Suzuki > > [...] > >>> >>> Please look at the CoreSight components specification 3.0 (ARM IHI >>> 0029E) Section B2.1.2 which describes the Unique Component Identifier >>> (UCI). >>> As mentioned above this consists of a combination of bits from >>> multiple registers, including PIDR4. >>> >> >> Ok got it now, thanks for clearing the doubt. I will go ahead with >> this method to identify QCOM impl and post a patch. >> > > Looking some more into this, since we have this limitation only on > specific replicator on very few QCOM SoCs, rather than having a blanket > workaround for all QCOM, we were thinking it would be better to have > this workaround based on a firmware property something like > "qcom,replicator-loses-context" for those replicators with this > limitation and then set the drvdata->check_idfilter_val based on > this property. > Sorry for going back and forth on this one, but I think having a firmware property will clearly help us identify the issue on specific SoCs rather than wholesale workaround for all QCOM SoCs. For now, I will post a patch based on the property "qcom,replicator-loses-context", please feel free to yell at me if this is completely wrong and we can discuss it further in that patch. Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation