Re: [PATCH v4 1/2] regulator: pf530x: Add a driver for the NXP PF5300 Regulator

Krzysztof Kozlowski
2025-09-04T05:44:38Z

On 03/09/2025 22:03, Woodrow Douglass wrote:
> This driver allows reading some regulator settings and adjusting
> output voltage. It is based on information from the datasheet
> at https://www.nxp.com/docs/en/data-sheet/PF5300.pdf
>
> Signed-off-by: Woodrow Douglass <wdouglass@carnegierobotics.com>
> ---
> MAINTAINERS | 6 +
> drivers/regulator/Kconfig | 12 ++
> drivers/regulator/Makefile | 1 +
> drivers/regulator/pf530x-regulator.c | 378 +++++++++++++++++++++++++++++++++++
> 4 files changed, 397 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6dcfbd11efef..2c2d165a40ff 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18291,6 +18291,12 @@ F: Documentation/devicetree/bindings/clock/*imx*
> F: drivers/clk/imx/
> F: include/dt-bindings/clock/*imx*
>
> +NXP PF5300/PF5301/PF5302 PMIC REGULATOR DEVICE DRIVER
> +M: Woodrow Douglass <wdouglass@carnegierobotics.com>
> +S: Maintained
> +F: Documentation/devicetree/bindings/regulator/nxp,pf530x-regulator.yaml
There is no such file at this stage.... but if you fix order, it would
be. Anyway, please be sure your patchsets are properly bisectable.

Please organize the patch documenting compatible (DT bindings) before
their user.
See also:
https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46

Best regards,
Krzysztof