Re: [PATCH v4 2/2] regulator: pf530x: dt-bindings: nxp,pf530x-regulator

Krzysztof Kozlowski
2025-09-04T13:05:59Z

On 04/09/2025 14:58, Woody Douglass wrote:
>>> +description: |
>>> + The PF5300, PF5301, and PF5302 integrate high-performance buck converters,
>>> + 12 A, 8 A, and 15 A, respectively, to power high-end automotive and industrial
>>> + processors. With adaptive voltage positioning and a high-bandwidth loop, they
>>> + offer transient regulation to minimize capacitor requirements.
>>> +
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - nxp,pf5300
>>> + - nxp,pf5301
>>> + - nxp,pf5302
>>
>> Still compatibility not expressed.
>>
>
> I'm sorry for the misunderstanding here -- I did reply (as Mark Brown mentioned in his
> reply to this email) in the cover letter for v3 of this patch (this message
> https://lore.kernel.org/lkml/20250902-pf530x-v3-0-4242e7687761@carnegierobotics.com/).
> Mark is right, I don't really understand what you're asking for, and other bindings for
> regulators seem to list off each compatible model in the way that I have. I have prepared
> a v5 of this patchset that incorporates the various comments, but I'll wait for some
> clarification here before submitting it.

Quick look at the driver suggests devices are fully compatible, so you
should express it with dedicated and fallback compatibles. See
example-schema or my OSSE25 beginners talk.

It might be that devices are not compatible, then it is enough to
explain that briefly (why they are not compatible) in the commit msg.

Best regards,
Krzysztof