From: David Ahern <dsahern@gmail.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Andi Kleen <andi@firstfloor.org>,
Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCHSET 00/10] perf sched timehist: Introduce --idle-hist option (v1)
Date: Tue, 6 Dec 2016 13:31:33 -0800 [thread overview]
Message-ID: <8290e8a9-eadd-8bca-d25b-0b5880a18f33@gmail.com> (raw)
In-Reply-To: <20161206194427.GC8257@kernel.org>
On 12/6/16 11:44 AM, Arnaldo Carvalho de Melo wrote:
> Em Tue, Dec 06, 2016 at 12:40:00PM +0900, Namhyung Kim escreveu:
>> Hi,
>>
>> This patchset implements the idle hist feature which analyze reason of system
>> idle. Sometimes I need to investigate what makes CPUs to go idle even though
>> I have jobs to do. It may be due to I/O, waiting on lock or whatever.
> So, on a first round, I've applied the ones David acked, will try
> pushing to Ingo today.
>
> David, I still haven't myself reviewed the patches, before that, do you
> have any strong objection to the other patches? Will you continue
> reviewing them?
patches 7-10 were fine. It's an interesting feature. My main concern was the changes to detecting idle_sample. If it works properly on RHEL6, RHEL7, and top of tree then it should be fine.
prev parent reply other threads:[~2016-12-06 21:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 3:40 [PATCHSET 00/10] perf sched timehist: Introduce --idle-hist option (v1) Namhyung Kim
2016-12-06 3:40 ` [PATCH 01/10] perf sched: Cleanup option processing Namhyung Kim
2016-12-06 3:58 ` David Ahern
2016-12-07 18:24 ` [tip:perf/core] " tip-bot for Namhyung Kim
2016-12-06 3:40 ` [PATCH 02/10] perf tools: Introduce callchain_cursor__copy() Namhyung Kim
2016-12-07 18:25 ` [tip:perf/core] perf callchain: " tip-bot for Namhyung Kim
2016-12-06 3:40 ` [PATCH 03/10] perf sched timehist: Handle zero sample->tid properly Namhyung Kim
2016-12-06 3:52 ` David Ahern
2016-12-06 3:59 ` Namhyung Kim
2016-12-06 4:01 ` David Ahern
2016-12-07 2:06 ` Namhyung Kim
2016-12-08 14:19 ` Namhyung Kim
2016-12-07 18:25 ` [tip:perf/core] " tip-bot for Namhyung Kim
2016-12-06 3:40 ` [PATCH 04/10] perf sched timehist: Split is_idle_sample() Namhyung Kim
2016-12-06 3:57 ` David Ahern
2016-12-07 1:26 ` Namhyung Kim
2016-12-06 3:40 ` [PATCH 05/10] perf sched timehist: Cleanup idle_max_cpu handling Namhyung Kim
2016-12-06 4:00 ` David Ahern
2016-12-07 18:26 ` [tip:perf/core] " tip-bot for Namhyung Kim
2016-12-06 3:40 ` [PATCH 06/10] perf sched timehist: Introduce struct idle_time_data Namhyung Kim
2016-12-06 4:07 ` David Ahern
2016-12-07 2:12 ` Namhyung Kim
2016-12-06 3:40 ` [PATCH 07/10] perf sched timehist: Save callchain when entering idle Namhyung Kim
2016-12-06 3:40 ` [PATCH 08/10] perf sched timehist: Skip non-idle events when necessary Namhyung Kim
2016-12-06 3:40 ` [PATCH 09/10] perf sched timehist: Add -I/--idle-hist option Namhyung Kim
2016-12-06 3:40 ` [PATCH 10/10] perf sched timehist: Show callchains for idle stat Namhyung Kim
2016-12-06 19:44 ` [PATCHSET 00/10] perf sched timehist: Introduce --idle-hist option (v1) Arnaldo Carvalho de Melo
2016-12-06 21:31 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8290e8a9-eadd-8bca-d25b-0b5880a18f33@gmail.com \
--to=dsahern@gmail.com \
--cc=andi@firstfloor.org \
--cc=arnaldo.melo@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).