From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751949AbcLFVtc (ORCPT ); Tue, 6 Dec 2016 16:49:32 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:35179 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750813AbcLFVta (ORCPT ); Tue, 6 Dec 2016 16:49:30 -0500 Subject: Re: [PATCHSET 00/10] perf sched timehist: Introduce --idle-hist option (v1) To: Arnaldo Carvalho de Melo References: <20161206034010.6499-1-namhyung@kernel.org> <20161206194427.GC8257@kernel.org> Cc: Namhyung Kim , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , Andi Kleen , Minchan Kim From: David Ahern Message-ID: <8290e8a9-eadd-8bca-d25b-0b5880a18f33@gmail.com> Date: Tue, 6 Dec 2016 13:31:33 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20161206194427.GC8257@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/6/16 11:44 AM, Arnaldo Carvalho de Melo wrote: > Em Tue, Dec 06, 2016 at 12:40:00PM +0900, Namhyung Kim escreveu: >> Hi, >> >> This patchset implements the idle hist feature which analyze reason of system >> idle. Sometimes I need to investigate what makes CPUs to go idle even though >> I have jobs to do. It may be due to I/O, waiting on lock or whatever. > So, on a first round, I've applied the ones David acked, will try > pushing to Ingo today. > > David, I still haven't myself reviewed the patches, before that, do you > have any strong objection to the other patches? Will you continue > reviewing them? patches 7-10 were fine. It's an interesting feature. My main concern was the changes to detecting idle_sample. If it works properly on RHEL6, RHEL7, and top of tree then it should be fine.