From: "Michael Kerrisk" <michael.kerrisk@gmx.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: davem@davemloft.net, roland@redhat.com, akpm@osdl.org,
mtk-lkml@gmx.net, linux-kernel@vger.kernel.org
Subject: Re: waitid() fails with EINVAL for SA_RESTART signals
Date: Mon, 30 May 2005 18:55:22 +0200 (MEST) [thread overview]
Message-ID: <8295.1117472122@www60.gmx.net> (raw)
In-Reply-To: Pine.LNX.4.58.0505261617360.2307@ppc970.osdl.org
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="us-ascii", Size: 967 bytes --]
> On Thu, 26 May 2005, David S. Miller wrote:
> >
> > > Other machines are subject to the same risk and should have a
> > > prevent_tail_call definition too. The asm-i386/linkage.h version
> > > probably
> > > works fine for every machine. It might as well be generic, I'd say.
> >
> > Sparc, for one, doesn't need it. We pass the pt_regs in via a pointer
> > to the trap level stack frame which won't be released by a tail-call
> > in C code.
>
> x86 has largely tried to move in that direction too, ie a lot of the
> asm-calls have been turned into FASTCALL() with %eax pointing to the
> stack.
>
> Roland, I applied the patch, but if there was some particular case that
> triggered this, maybe it's worth trying to re-write that one.
Did I miss something. Did this patch come through the
list? (I didn't see it.)
Cheers,
Michael
--
5 GB Mailbox, 50 FreeSMS http://www.gmx.net/de/go/promail
+++ GMX - die erste Adresse für Mail, Message, More +++
prev parent reply other threads:[~2005-05-30 16:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-18 8:20 waitid() fails with EINVAL for SA_RESTART signals Michael Kerrisk
2005-05-26 21:17 ` Roland McGrath
2005-05-26 22:21 ` [PATCH] i386: fix prevent_tail_call Roland McGrath
2005-05-26 22:22 ` waitid() fails with EINVAL for SA_RESTART signals Roland McGrath
2005-05-26 22:37 ` David S. Miller
2005-05-26 23:19 ` Linus Torvalds
2005-05-26 23:22 ` Roland McGrath
2005-05-27 0:03 ` Parag Warudkar
2005-05-27 0:11 ` Roland McGrath
2005-05-27 0:37 ` Parag Warudkar
2005-05-27 1:05 ` Parag Warudkar
2005-05-27 2:01 ` Parag Warudkar
2005-05-30 16:55 ` Michael Kerrisk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8295.1117472122@www60.gmx.net \
--to=michael.kerrisk@gmx.net \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk-lkml@gmx.net \
--cc=roland@redhat.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox