From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80B012BE7BB for ; Tue, 2 Dec 2025 19:11:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764702664; cv=none; b=Jh1XtbRZwDFY77BlA/Pf52AVix2Xuucrl3fTwPuIpo6+XlnmmWtgDk2YIpkT1ee08YZxLZ2j0BIZi4lRU1X8AfOq9sXjbKDNvxrzY3wPDi+7EtPXxKw9fxd712RCEdf23RG1t4Urb3ZYW5owGdHnACQN8kYdXEeEuL9ayr+DC9w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764702664; c=relaxed/simple; bh=Ae640Ee86InL2k/ZiK65Gw8rrEj5J518vdVt9OblFCM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kcjvQLTfRKsJdYQwWUANNInVrD4DwKBYMzhZFTyUWvU27ox6fWCYxiJcwhCt1s23TaCL8/z6w1LQyf8L/6FF+b/AaBxOLXUhQVxJA+EJcyyhK36loLA/9DcOn69neq9Zj8xzo3mCucpymHlo53X9Kwu7DbCojvGzBTnR25jkex0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lbvhNOR8; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lbvhNOR8" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-47778b23f64so34435695e9.0 for ; Tue, 02 Dec 2025 11:11:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764702661; x=1765307461; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/FUr//0TUGWxEnNiBNXorIHtkzvmnOQuNFmiIiuZ+wU=; b=lbvhNOR8ET50v2g2b0aRDV7qtOIz9mTJrKQKrqUSVLPijPTRgcXa+fPWo3O/QMMeKi MJJa7KqElvc11XwtIxU6Xp6YZOUCvNOP+oltVqVpT730pHy6YAdOYaMp1YlMVSgNaDOM jIIYIGQRBfozBVoThrxkWVTwWMqAzrLiSsc4u7I0UzqWAueT4n03kOHYzuHe/l5utKCr giO4F8htRyDRtiLH0uU3ejGOIzebG3TTp7gpzeRgZ9J/rdRvEaIXVCW/EP2qqrj9fXKF WweJCOonObmhAcEXYjV+30OW/xwhAEhJ9y6n2PlFLWio6hfnDuCMtwoGzZRN0j5YSsrG 4WdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764702661; x=1765307461; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/FUr//0TUGWxEnNiBNXorIHtkzvmnOQuNFmiIiuZ+wU=; b=RGqYY2/WQ4GCQdtYXsz5GaBOpcVresw/5b5cUgjHZxDV6gCISYtyBh6YzG62zLO+2x 1w1hcDXcLBA84ZTixml1faqfxQCQtXy5VQa3d4fNCSDqYrfgWqZPKOAz+M8Eg1DxjxxW 9RGTFowc1yJFNgsAdVg/vD21eAoduR3cIzz6NqGR6TI3T09UATnQaoLmG0FMAkKE/Nca BlqHZiZy5MMLId/BBijZZiFqE2bv8BkqHmuJ5avd01F89wi6PioGHNeXXyDpcg3tITY7 bX+h1JhOgS4sV4hGqp2fCqpSsSCGqdp4XelIEfb/z+65YL7x/VvV6bdsrqWzObsaRPHI clhg== X-Forwarded-Encrypted: i=1; AJvYcCVRskmN3DRJWeP9ZUG338qUJPl4jiA9D8mEH3SnC9ueAlMfEVf466zzsgBrAONtAkrpfOHuFkgrPPWkFEc=@vger.kernel.org X-Gm-Message-State: AOJu0YzflIP6i4oa1+qxhc3t3qbNfF3vlnYdF6RSVqSSRWLE498Un+Ti bGHnt2qQ5dhKc9ETn2rrsBnczbgqgIuhGVcp+ctaGzmKM9/G9BDni3yH X-Gm-Gg: ASbGncu2HbPEU/+yn059WgwxtgESfnHUWo5W4hQpOF5a+XXOoBbIerrX9KgPxaay6Vq 6aKGaWnxrTlnB5w7/ciVrprzZT98T9PImibW4ZCN2cnUN1q58oCXdwHFrobWjtuT9VnWiIJaXaz 4nTYVaakkCwqTPGJCJxgHPKHraukQmzitF+/AkJ5kaBAkG+gS+LdWXeH52ZZ0cwpHRgR++Q66ED AUUcw316ETO06vYcO+ZMN9jomPjAnw6Opj5eQECX/RAw/mMaQYTJpyWOugS87G536io3TWkaAAD O5ZmQDDLXkWmiHGDoeZYQ+E7ww+RPzxCQ+uU8bLHk+hX2wVX4Y/xeR67PtpagjXXwve9PTuoFLg 5+aWQvg61IS3ZDmQgkvKViqgijBx+vryb2bS+NIqGoZTSbb+aDxqWJyr4ClP5dx9oh5mNveOobx XVyeHNotkO+phZbv82JR1/GM3Coq8wkuUCOHpKcQ+AJqGFyaK1if4acubwPYNmdGKj+zhG24xWm 01ckrfr41Oqb4f8NVbWNbdbT8NchzudqmRktPBm5mHWNi5ZaFUruA== X-Google-Smtp-Source: AGHT+IEgZF6obM1hz4fa+Aa1eE42zQzGnr5+d/JhxTBfn+xzybZBw+XMc01RajHHQ6tlE7TseQ1RDw== X-Received: by 2002:a05:600c:6304:b0:471:9da:5248 with SMTP id 5b1f17b1804b1-4792a4ba83cmr7942335e9.26.1764702660647; Tue, 02 Dec 2025 11:11:00 -0800 (PST) Received: from ?IPV6:2003:ea:8f22:cb00:61e9:ed14:30da:92bc? (p200300ea8f22cb0061e9ed1430da92bc.dip0.t-ipconnect.de. [2003:ea:8f22:cb00:61e9:ed14:30da:92bc]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4792a620b13sm3397225e9.2.2025.12.02.11.10.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Dec 2025 11:11:00 -0800 (PST) Message-ID: <82984a56-5bea-48ef-98ed-20d83377808e@gmail.com> Date: Tue, 2 Dec 2025 20:10:59 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net V2] r8169: fix RTL8117 Wake-on-Lan in DASH mode To: =?UTF-8?Q?Ren=C3=A9_Rebe?= , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: nic_swsd@realtek.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , =?UTF-8?Q?fran=C3=A7ois_romieu?= References: <20251202.194137.1647877804487085954.rene@exactco.de> Content-Language: en-US From: Heiner Kallweit In-Reply-To: <20251202.194137.1647877804487085954.rene@exactco.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 12/2/2025 7:41 PM, René Rebe wrote: > Wake-on-Lan does currently not work for r8169 in DASH mode, e.g. the > ASUS Pro WS X570-ACE with RTL8168fp/RTL8117. > > Fix by not returning early in rtl_prepare_power_down when dash_enabled. > While this fixes WoL, it still kills the OOB RTL8117 remote management > BMC connection. Fix by not calling rtl8168_driver_stop if WoL is enabled. > > Fixes: 065c27c184d6 ("r8169: phy power ops") > Signed-off-by: René Rebe > Cc: stable@vger.kernel.org > --- > V2; DASH WoL fix only > Tested on ASUS Pro WS X570-ACE with RTL8168fp/RTL8117 running T2/Linux. > --- Reviewed-by: Heiner Kallweit