From: Yunsheng Lin <linyunsheng@huawei.com>
To: <davem@davemloft.net>, <kuba@kernel.org>,
<a.fatoum@pengutronix.de>, <vladimir.oltean@nxp.com>
Cc: <olteanv@gmail.com>, <ast@kernel.org>, <daniel@iogearbox.net>,
<andriin@fb.com>, <edumazet@google.com>, <weiwan@google.com>,
<cong.wang@bytedance.com>, <ap420073@gmail.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linuxarm@openeuler.org>, <mkl@pengutronix.de>,
<linux-can@vger.kernel.org>, <jhs@mojatatu.com>,
<xiyou.wangcong@gmail.com>, <jiri@resnulli.us>,
<andrii@kernel.org>, <kafai@fb.com>, <songliubraving@fb.com>,
<yhs@fb.com>, <john.fastabend@gmail.com>, <kpsingh@kernel.org>,
<bpf@vger.kernel.org>, <jonas.bonn@netrounds.com>,
<pabeni@redhat.com>, <mzhivich@akamai.com>, <johunt@akamai.com>,
<albcamus@gmail.com>, <kehuan.feng@gmail.com>,
<a.fatoum@pengutronix.de>, <atenart@kernel.org>,
<alexander.duyck@gmail.com>, <hdanton@sina.com>,
<jgross@suse.com>, <JKosina@suse.com>, <mkubecek@suse.cz>,
<bjorn@kernel.org>, <alobakin@pm.me>
Subject: Re: [Linuxarm] [PATCH RFC v4 0/3] Some optimization for lockless qdisc
Date: Thu, 20 May 2021 17:45:14 +0800 [thread overview]
Message-ID: <829cc4c1-46cc-c96c-47ba-438ae3534b94@huawei.com> (raw)
In-Reply-To: <1621502873-62720-1-git-send-email-linyunsheng@huawei.com>
On 2021/5/20 17:27, Yunsheng Lin wrote:
> Patch 1: remove unnecessary seqcount operation.
> Patch 2: implement TCQ_F_CAN_BYPASS.
> Patch 3: remove qdisc->empty.
>
> RFC v4: Use STATE_MISSED and STATE_DRAINING to indicate non-empty
> qdisc, and add patch 1 and 3.
@Vladimir, Ahmad
It would be good to run your testcase to see if there are any
out of order for this version, because this version has used
STATE_MISSED and STATE_DRAINING to indicate non-empty qdisc,
thanks.
It is based on newest net branch with qdisc stuck patchset.
Some performance data as below:
pktgen + dummy netdev:
threads without+this_patch with+this_patch delta
1 2.60Mpps 3.18Mpps +22%
2 3.84Mpps 5.72Mpps +48%
4 5.52Mpps 5.52Mpps +0.0%
8 2.77Mpps 2.81Mpps +1.4%
16 2.24Mpps 2.29Mpps +2.2%
IP forward testing: 1.05Mpps increases to 1.15Mpps
>
> Yunsheng Lin (3):
> net: sched: avoid unnecessary seqcount operation for lockless qdisc
> net: sched: implement TCQ_F_CAN_BYPASS for lockless qdisc
> net: sched: remove qdisc->empty for lockless qdisc
>
> include/net/sch_generic.h | 26 +++++++++++++-------------
> net/core/dev.c | 22 ++++++++++++++++++++--
> net/sched/sch_generic.c | 23 ++++++++++++++++-------
> 3 files changed, 49 insertions(+), 22 deletions(-)
>
next prev parent reply other threads:[~2021-05-20 9:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 9:27 [PATCH RFC v4 0/3] Some optimization for lockless qdisc Yunsheng Lin
2021-05-20 9:27 ` [PATCH RFC v4 1/3] net: sched: avoid unnecessary seqcount operation " Yunsheng Lin
2021-05-20 9:27 ` [PATCH RFC v4 2/3] net: sched: implement TCQ_F_CAN_BYPASS " Yunsheng Lin
2021-05-20 9:27 ` [PATCH RFC v4 3/3] net: sched: remove qdisc->empty " Yunsheng Lin
2021-05-20 9:45 ` Yunsheng Lin [this message]
2021-05-20 13:46 ` [Linuxarm] [PATCH RFC v4 0/3] Some optimization " Vladimir Oltean
2021-05-21 14:14 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=829cc4c1-46cc-c96c-47ba-438ae3534b94@huawei.com \
--to=linyunsheng@huawei.com \
--cc=JKosina@suse.com \
--cc=a.fatoum@pengutronix.de \
--cc=albcamus@gmail.com \
--cc=alexander.duyck@gmail.com \
--cc=alobakin@pm.me \
--cc=andrii@kernel.org \
--cc=andriin@fb.com \
--cc=ap420073@gmail.com \
--cc=ast@kernel.org \
--cc=atenart@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cong.wang@bytedance.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hdanton@sina.com \
--cc=jgross@suse.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=johunt@akamai.com \
--cc=jonas.bonn@netrounds.com \
--cc=kafai@fb.com \
--cc=kehuan.feng@gmail.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=mkl@pengutronix.de \
--cc=mkubecek@suse.cz \
--cc=mzhivich@akamai.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=songliubraving@fb.com \
--cc=vladimir.oltean@nxp.com \
--cc=weiwan@google.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox