From: Shuah Khan <skhan@linuxfoundation.org>
To: Zheng Wang <zyytlz.wz@163.com>, valentina.manea.m@gmail.com
Cc: shuah@kernel.org, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
hackerzheng666@gmail.com, 1395428693sheep@gmail.com,
alex000young@gmail.com, Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v3] usbip: vudc: Fix use after free bug in vudc_remove due to race condition
Date: Thu, 16 Mar 2023 11:57:44 -0600 [thread overview]
Message-ID: <829d7a70-8e73-43fd-e819-6ced8c83c12e@linuxfoundation.org> (raw)
In-Reply-To: <20230316174432.1592087-1-zyytlz.wz@163.com>
On 3/16/23 11:44, Zheng Wang wrote:
> In vudc_probe, it calls init_vudc_hw, which bound &udc->timer with v_timer.
>
> When it calls usbip_sockfd_store, it will call v_start_timer to start the
> timer work.
>
> When we call vudc_remove to remove the driver, theremay be a sequence as
> follows:
>
When you resend the patch as you indicated would, please add details
on how you found this proble,m.
> Fix it by shutdown the timer work before cleanup in vudc_remove.
>
thanks,
-- Shuah
next prev parent reply other threads:[~2023-03-16 17:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 17:44 [PATCH v3] usbip: vudc: Fix use after free bug in vudc_remove due to race condition Zheng Wang
2023-03-16 17:47 ` Zheng Hacker
2023-03-16 17:57 ` Shuah Khan [this message]
2023-03-16 18:02 ` Zheng Hacker
-- strict thread matches above, loose matches on Subject: below --
2023-03-17 10:09 Zheng Wang
2023-03-17 22:53 ` Shuah Khan
2023-03-18 7:39 ` Zheng Hacker
2023-04-13 8:09 ` Zheng Hacker
2023-04-13 18:01 ` Shuah Khan
2023-04-14 2:33 ` Zheng Hacker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=829d7a70-8e73-43fd-e819-6ced8c83c12e@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=1395428693sheep@gmail.com \
--cc=alex000young@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hackerzheng666@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=valentina.manea.m@gmail.com \
--cc=zyytlz.wz@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox