Re: [PATCH v3 2/7] clocksource: Add Tegra186 timers support

Dmitry Osipenko
2020-04-03T21:07:07Z

03.04.2020 23:51, Dmitry Osipenko пишет:
> 03.04.2020 23:22, Thierry Reding пишет:
> ...
>> +static irqreturn_t tegra186_timer_irq(int irq, void *data)
>> +{
>> + struct tegra186_timer *tegra = data;
>> +
>> + if (watchdog_active(&tegra->wdt->base)) {
>> + tegra186_wdt_disable(tegra->wdt);
>> + tegra186_wdt_enable(tegra->wdt);
>> + }
>
> Shouldn't this return IRQ_NONE if watchdog is inactive?
>
>> + return IRQ_HANDLED;
>> +}
>

Could you please explain why this interrupt handler is needed at all?
Shouldn't the watchdog's core take care of the pinging?