Re: [PATCH 1/6] dt-bindings: clock: imx8m-anatop: support spread spectrum clocking

Krzysztof Kozlowski
2024-10-23T17:49:42Z

On 23/10/2024 16:58, Dario Binacchi wrote:
>>>>
>>>> This is another commit [1] on enabling spread spectrum that I
>>>> implemented some time ago for
>>>> the am335x. The most evident difference is that in that case the node
>>>> was a clock node and not
>>>> a clock controller, as in the case of anatop. The parameters are also
>>>> not exactly the same, but
>>>> that depends on the platform.
>>>>
>>>> [1] 4a8bc2644ef0cbf8e ("dt-bindings: ti: dpll: add spread spectrum support")
>>>
>>>
>>> OK, I still do not know what "0" was, but the items are fixed, so you
>>> know exactly which clock you are configuring here.
>>
>> So, after delving deeper into the topic, is it now acceptable to use
>> the property
>> "fsl,ssc-clocks" instead of "clocks"? As in the patch I applied locally?
>
> A gentle ping.
> Sorry, but I haven't yet received your response to the previous email,
> and I'm not sure how to proceed.
>

Yeah, the property is fine, but I don't think you need the clock index.
The lists - like clocks and your spread property - have strictly defined
items, so it is enough if schema lists items and says which spread
points to which clock.

P.S. I think you might pinged me on IRC, but you know,
https://nohello.net/en/

Best regards,
Krzysztof