Re: [PATCH 1/6] dt-bindings: clock: imx8m-anatop: support spread spectrum clocking

Dario Binacchi
2024-09-29T20:00:39Z

On Sat, Sep 28, 2024 at 2:09 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 28/09/2024 10:37, Dario Binacchi wrote:
> > The patch adds the DT bindings for enabling and tuning spread spectrum
> > clocking generation.
> >
> > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> > ---
> >
> > .../bindings/clock/fsl,imx8m-anatop.yaml | 41 +++++++++++++++++++
> > 1 file changed, 41 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/fsl,imx8m-anatop.yaml b/Documentation/devicetree/bindings/clock/fsl,imx8m-anatop.yaml
> > index bbd22e95b319..c91eb4229ed3 100644
> > --- a/Documentation/devicetree/bindings/clock/fsl,imx8m-anatop.yaml
> > +++ b/Documentation/devicetree/bindings/clock/fsl,imx8m-anatop.yaml
> > @@ -32,6 +32,47 @@ properties:
> >
> > '#clock-cells':
> > const: 1
> > +if:
>
> This should be allOf: and placed after required: block, like in example
> schema.
>
>
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - fsl,imx8mm-anatop
> > +
> > +then:
> > + properties:
> > + fsl,ssc-clocks:
>
> Nope. Properties must be defined in top-level.
>
> > + $ref: /schemas/types.yaml#/definitions/phandle-array
> > + description:
> > + The phandles to the PLLs with spread spectrum clock generation
> > + hardware capability.
>
> These should be clocks.

Sorry, but I can't understand what you're asking me.
Could you kindly explain it to me in more detail?

>
> > + maxItems: 4
> > +
> > + fsl,ssc-modfreq-hz:
> > + $ref: /schemas/types.yaml#/definitions/uint32-array
>
> This should fail. I don't think you tested this patch.

I executed the command

make dt_binding_check DT_SCHEMA_FILES=fsl,imx8m-anatop.yaml

and it did not raise any errors.

Thanks and regards,
Dario

>
> https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/property-units.yaml
>
> > + description:
> > + The values of modulation frequency (Hz unit) of spread spectrum
> > + clocking for each PLL.
> > + maxItems: 4
> > +
> > + fsl,ssc-modrate-percent:
>
> Same problems
>
>
>
> Best regards,
> Krzysztof
>

--

Dario Binacchi

Senior Embedded Linux Developer

dario.binacchi@amarulasolutions.com

__________________________________

Amarula Solutions SRL

Via Le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 042 243 5310
info@amarulasolutions.com