Re: [PATCH 1/6] dt-bindings: clock: imx8m-anatop: support spread spectrum clocking

Krzysztof Kozlowski
2024-09-28T12:09:09Z

On 28/09/2024 10:37, Dario Binacchi wrote:
> The patch adds the DT bindings for enabling and tuning spread spectrum
> clocking generation.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
>
> .../bindings/clock/fsl,imx8m-anatop.yaml | 41 +++++++++++++++++++
> 1 file changed, 41 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/fsl,imx8m-anatop.yaml b/Documentation/devicetree/bindings/clock/fsl,imx8m-anatop.yaml
> index bbd22e95b319..c91eb4229ed3 100644
> --- a/Documentation/devicetree/bindings/clock/fsl,imx8m-anatop.yaml
> +++ b/Documentation/devicetree/bindings/clock/fsl,imx8m-anatop.yaml
> @@ -32,6 +32,47 @@ properties:
>
> '#clock-cells':
> const: 1
> +if:

This should be allOf: and placed after required: block, like in example
schema.

> + properties:
> + compatible:
> + contains:
> + enum:
> + - fsl,imx8mm-anatop
> +
> +then:
> + properties:
> + fsl,ssc-clocks:

Nope. Properties must be defined in top-level.

> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + description:
> + The phandles to the PLLs with spread spectrum clock generation
> + hardware capability.

These should be clocks.

> + maxItems: 4
> +
> + fsl,ssc-modfreq-hz:
> + $ref: /schemas/types.yaml#/definitions/uint32-array

This should fail. I don't think you tested this patch.

https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/property-units.yaml

> + description:
> + The values of modulation frequency (Hz unit) of spread spectrum
> + clocking for each PLL.
> + maxItems: 4
> +
> + fsl,ssc-modrate-percent:

Same problems

Best regards,
Krzysztof