From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752622AbdJ0MhR (ORCPT <rfc822;w@1wt.eu>);
        Fri, 27 Oct 2017 08:37:17 -0400
Received: from mout.web.de ([212.227.17.11]:64473 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752473AbdJ0MhM (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 27 Oct 2017 08:37:12 -0400
Subject: Re: iio/accel/stk8312: Improve unlocking of a mutex in two functions
To: Peter Meerwald-Stadler <pmeerw@pmeerw.net>, linux-iio@vger.kernel.org
Cc: Jonathan Cameron <jic23@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <ae9d7e7f-541e-ce0c-1d41-6b9793c98f78@users.sourceforge.net>
 <20171026170913.5ff10718@archlinux>
 <c2620449-b80a-f0ef-c0d2-92d0c7fb4906@users.sourceforge.net>
 <alpine.DEB.2.20.1710271254570.17368@vps.pmeerw.net>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <82e2fde9-2b35-be54-4614-977fc2894da1@users.sourceforge.net>
Date: Fri, 27 Oct 2017 14:37:04 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1710271254570.17368@vps.pmeerw.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:KDhGAzosgck40vKP9q4W8sVc7R7tWP3ed6gBU8FmQUiwWwe2kNG
 LJRn31Pawd1VITQhcrTH3JoktzuoVgOTrK3saWW/u+NZEhAvAqfF63BWRwu9Ou0a3FaXrFD
 GSWnX8YK2xT/qpJT8PBID2fY+aORfXcePaGpLXf+yPV7bVXDw6fNiRa0XSaX28whfnmfh+n
 BzYKeunV2pso5nQdkKxBw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:S3m64dYXpJQ=:7bNNI0tIbzZj1NsQvZUl1T
 Hyyhblhrl+4qpRnxjscoN5L96b9WKfq8lNPiN4DuPTuuVDVFxSyNGe7al0eVrLgduWESdYbVe
 eiSteKvfqKq7YytoxlXzoLSgD1oDFvA7vjed3PR7da5EzNmw+UVMn7vJsFDhNMENi5jjJI8Ke
 4YFSw3CuNpV4nFJlfzR4dPerB6YNP8cYL/dQ8pGBAlM3qPGxm0fck/GS4H47TM838sTPE1Qcz
 0nLOp12pP0nUBCCqp0egQsi0To0ym9lYFfPfn8q6pITHqvqwRJWqAfDu8c+l7+Pxw9OCg+wM8
 qcVzluSNS2EO2I8gsd4/kZLDlYj2D7DHkaQtc/b4NfTPxFqt38QOfoV1z358/MG2Jr/iAGlwN
 hQ+SH1xPNUp3jQGs9RxmpQ6wx06lDLX/xvJsgzJgxZPerD6G0fNrbm/oytFzpLTNgvNxa/8/6
 zLMT5xpw7oJz3/xuo6iXvVmJK9Gmn21vWqpy2S3n2JmyPWuL92wLRcEWHgR2pmqED3zfFtgDo
 q8PDKtANRTXAo3ZtcXk3tb6a0VoTwag8ki2xraMVuBfRCN9TI07fwTUX8FLSBN3V7j98zElaX
 OGRRZ1QTqGlZaES5CFflktTKtEImS9knSyzmTR6Rlf9/DfM4Za68tf/8OSArJH+uhupQq6Ekm
 XGSG1PwkC7jTOj0XDjhBdk2uLDGRTm54bZKF/5mWMiX+5fQ6hZH4Bjs8gJC/2ZBuwZ2rNHH+2
 iRv7a9cuy44ZCjFCpkP5vf2t7UTVT2j+PgxyrnUF0Ed5qGGvd4XR4zQ/iGBoGWj94BkSVm73q
 2RarDTS/1Aagm7de7dag1up0f50nHiL3ryFj7L4CaehAo5Al10=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> But I proposed an other source code layout for useful reasons.
> 
> I think there is a (hidden) cost of having pure cleanup patches:
> they make backporting fixes harder (across the cleanup)

There the usual software development consequences to consider
if you dare to change the source code at all.


> stylistic changes must have a clear benefit, readability is subjective, 
> consistency per se doesn't buy anything

There are also different opinions involved.


> the discussion how code should be written in the first place is separate
> from the discussion what is worth fixing up lateron (IMHO)

Are you looking for a corresponding agreement?

Regards,
Markus