public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Parag Warudkar" <parag.warudkar@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
	"akpm@osdl.org" <akpm@osdl.org>, "Ingo Molnar" <mingo@elte.hu>,
	"Peter Zijlstra" <peterz@infradead.org>
Subject: [PATCH] default to n for GROUP_SCHED and FAIR_GROUP_SCHED
Date: Sat, 3 May 2008 20:42:34 -0400	[thread overview]
Message-ID: <82e4877d0805031742o464dd581wd93173d79705ce0d@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 864 bytes --]

GROUP_SCHED is confirmed to cause unacceptable latencies -
http://lkml.org/lkml/2008/5/2/370.

Besides there is no reason for it to be on by default.

Mark it EXPERIMENTAL and default to no.

Patch also attached.

Signed-off-by: Parag Warudkar <parag.warudkar@gmail.com>

--- linux-2.6/init/Kconfig.orig	2008-05-03 20:14:41.000000000 -0400
+++ linux-2.6/init/Kconfig	2008-05-03 20:29:06.000000000 -0400
@@ -318,7 +318,8 @@

 config GROUP_SCHED
 	bool "Group CPU scheduler"
-	default y
+	depends on EXPERIMENTAL
+	default n
 	help
 	  This feature lets CPU scheduler recognize task groups and control CPU
 	  bandwidth allocation to such task groups.
@@ -326,7 +327,7 @@
 config FAIR_GROUP_SCHED
 	bool "Group scheduling for SCHED_OTHER"
 	depends on GROUP_SCHED
-	default y
+	default GROUP_SCHED

 config RT_GROUP_SCHED
 	bool "Group scheduling for SCHED_RR/FIFO"

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: init_kconfig.patch --]
[-- Type: text/x-diff; name=init_kconfig.patch, Size: 845 bytes --]

GROUP_SCHED is confirmed to cause unacceptable latencies -
http://lkml.org/lkml/2008/5/2/370. 

Besides there is no reason for it to be on by default.

Mark it EXPERIMENTAL and default to no.

Signed-off-by: Parag Warudkar <parag.warudkar@gmail.com>

--- linux-2.6/init/Kconfig.orig	2008-05-03 20:14:41.000000000 -0400
+++ linux-2.6/init/Kconfig	2008-05-03 20:29:06.000000000 -0400
@@ -318,7 +318,8 @@
 
 config GROUP_SCHED
 	bool "Group CPU scheduler"
-	default y
+	depends on EXPERIMENTAL
+	default n
 	help
 	  This feature lets CPU scheduler recognize task groups and control CPU
 	  bandwidth allocation to such task groups.
@@ -326,7 +327,7 @@
 config FAIR_GROUP_SCHED
 	bool "Group scheduling for SCHED_OTHER"
 	depends on GROUP_SCHED
-	default y
+	default GROUP_SCHED
 
 config RT_GROUP_SCHED
 	bool "Group scheduling for SCHED_RR/FIFO"

             reply	other threads:[~2008-05-04  0:42 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-04  0:42 Parag Warudkar [this message]
2008-05-04  9:24 ` [PATCH] default to n for GROUP_SCHED and FAIR_GROUP_SCHED Ingo Molnar
2008-05-05 15:14   ` Parag Warudkar
2008-05-05 17:15     ` Ingo Molnar
2008-05-05 18:24       ` Sam Ravnborg
2008-05-05 18:36         ` Sergio Luis
2008-05-05 18:45           ` Ingo Molnar
2008-05-05 19:49             ` [PATCH] kconfig: add support for stdin (make K=- ...) Sam Ravnborg
2008-05-06  3:51               ` Oleg Verych
2008-05-05 19:05           ` [PATCH] default to n for GROUP_SCHED and FAIR_GROUP_SCHED Sam Ravnborg
2008-05-05 18:42         ` Ingo Molnar
2008-05-05 19:01           ` Sam Ravnborg
2008-05-05 19:56           ` Arjan van de Ven
2008-05-05 20:27             ` Ingo Molnar
2008-05-05 20:48               ` Linus Torvalds
2008-05-05 21:05                 ` Ingo Molnar
2008-05-05 21:40                   ` Parag Warudkar
2008-05-25 19:30       ` Roman Zippel
2008-05-05 17:21     ` Ingo Molnar
2008-05-05 17:33       ` Jesse Barnes
2008-05-05 18:36         ` Ingo Molnar
2008-05-05 21:36       ` Parag Warudkar
2008-05-05 21:49         ` Ingo Molnar
2008-05-06  0:38           ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82e4877d0805031742o464dd581wd93173d79705ce0d@mail.gmail.com \
    --to=parag.warudkar@gmail.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox