public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: open list <linux-kernel@vger.kernel.org>,
	linux-gpio@vger.ekernel.org,
	Linus Walleij <linus.walleij@linaro.org>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	Andrew Lunn <andrew@lunn.ch>
Subject: Warnings from include/linux/gpio/consumer.h with CONFIG_GPIOLIB=n
Date: Fri, 1 Sep 2017 21:49:40 -0700	[thread overview]
Message-ID: <82f82952-dedd-ce4f-e339-c69dac241a8a@gmail.com> (raw)

Hi Linus,

I think Sergei or someone else was mentioning that before a while ago,
but when CONFIG_GPIOLIB=n most gpiod_* inline stubs have WARN_ON() that
will scare people.

What do you recommend doing for code that might be built with or without
CONFIG_GPIOLIB, should we just encapsulate the part that deals with
GPIOs under an #if IS_ENABLED(CONFIG_GPIOLIB) or something? The
particular piece of code that I just saw this with is
drivers/net/phy/mdio_bus.c.

Thanks!
-- 
Florian

             reply	other threads:[~2017-09-02  4:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-02  4:49 Florian Fainelli [this message]
2017-09-12  7:25 ` Warnings from include/linux/gpio/consumer.h with CONFIG_GPIOLIB=n Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82f82952-dedd-ce4f-e339-c69dac241a8a@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.ekernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox