From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11010025.outbound.protection.outlook.com [52.101.85.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A99E233291F for ; Tue, 7 Jul 2026 16:07:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.85.25 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783440454; cv=fail; b=E/wEFdpeCMYjzupLCPJqjd4KKAW8OJ5UJ/u9iTs2swaOIi6c3vrlXpeKIxet6uPllvXf+RLhknlGswy35FWpp0SQrFOZ+eRzkwjvMeD4HW76beCtoiOpIuoZ0W+EmrWgxjELbd3HmCMI2HUL7SHEHH4YmvLbOmLzpu3oH6NBoxc= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783440454; c=relaxed/simple; bh=R+CU8FnKo9/gWEaCDyop9IT3yvoAcJr5/KikQVoPotE=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=HoGNTP2BFWDvlch2unbODfP2DspSUyPkyje4raxVKmtaQQ3m+XpLLQ+DCTonK8fCIEqzcDVLCgLXnUeGIv9EMXa2KJ9Ot1oZJhkS01TGB0S2v3YHyMkUdRCEYimPDp4z53iqmblk7q3JK3jB+qq+YpjeI23vLDMbF9lrEZOLRlo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=qXQFEJJc; arc=fail smtp.client-ip=52.101.85.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="qXQFEJJc" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=t+tb3Lj8W3q3BYXxe1ssUgkgfwke5641OixcCG/vPAj/NdonRsTVmC/FZ4fx0wJ2We49Zyhj976xDuo3MDEs+Hhjk4SF5ehBAFCpkOxrnyS353sABnFlUj8wlHN27l0+c2U0rx0beEKCCHlfZIa9SEyUC+IYdoh8G86ElIU9nW3vpiP1KXU5Lykl8f6Pf5dvi88tmqfyJnticduWfdI34/Lp9GE7bYiGZ6snmEgT1ALw5hev2I4AQRWP14UCo+4zgQNwKRCNTllfczLAb2QyeliU+XEYwaqpnR5ZPf1BKzCd6l0mHFF/B5h1sXjqSNFjhrMAGQNwCsU1i3ODO0kACw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x1MZVNYsskYJQzMWWPX6XrT5XftJA0jlJ/IQSmw5HG8=; b=KKqd+42b0A08jLNfVt1W1E1BQX/cKHP4Awo0M4OSaAiA+avqdQhaPVyrxPJrbp6COglw2+REqtDOhWfsiO1Tkm92ZpeJQcRweitMjoVWBX2yD0Areoh3fYvvhw1/N9FubvuEoPsxvvphu7yiLxKqfN0MBq8s9NOQpUSdIk+rAtCF0fAgDuaDxXwhyA0IXt5UIJKcEZRlwyz8H79Ip9bA6/wBn4F+PDWTLt/Fess9igqSbdlyamQLtsa3Hm0gbiEqN+V8ZVxcATJx1jpwqAECaBJlxModu1+Ia0yn+uTaApS4vAbC0N4gHxxbfL6rPi6E/0kPXi6vLHkDLP5xEZt96Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x1MZVNYsskYJQzMWWPX6XrT5XftJA0jlJ/IQSmw5HG8=; b=qXQFEJJc8kVT3muL+lGJASqyqdUp+mEGjeQ2DsyZ7cnhM/N7FB9FUgdSzC7zhgIirhTv4q6aYcZkJDLBtmsOIFi2aTrVpkFjOY7BrY9wgYe8gdixPn6BE+k8vrIZr6k37VZK/je1FHW67C7aW5iNB0ukhk1jcMne1lWVjLfQUro= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SN7PR12MB8131.namprd12.prod.outlook.com (2603:10b6:806:32d::12) by CY8PR12MB8337.namprd12.prod.outlook.com (2603:10b6:930:7d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.10; Tue, 7 Jul 2026 16:07:26 +0000 Received: from SN7PR12MB8131.namprd12.prod.outlook.com ([fe80::c2dd:62c5:67fe:aa46]) by SN7PR12MB8131.namprd12.prod.outlook.com ([fe80::c2dd:62c5:67fe:aa46%4]) with mapi id 15.21.0181.009; Tue, 7 Jul 2026 16:07:25 +0000 Message-ID: <82f90ab5-0849-40f5-8f90-1aff2ca11e97@amd.com> Date: Tue, 7 Jul 2026 11:07:23 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] x86/virt/sev: Revert "Drop WBINVD before setting MSR_AMD64_SYSCFG_SNP_EN" To: Tycho Andersen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Cc: Ashish Kalra , Nikunj A Dadhania , Kees Cook , linux-kernel@vger.kernel.org, Srikanth.Aithal@amd.com, David.Kaplan@amd.com, Yazen.Ghannam@amd.com References: <20260707150033.2364758-1-tycho@kernel.org> From: Tom Lendacky Content-Language: en-US Autocrypt: addr=thomas.lendacky@amd.com; keydata= xsFNBFaNZYkBEADxg5OW/ajpUG7zgnUQPsMqWPjeAxtu4YH3lCUjWWcbUgc2qDGAijsLTFv1 kEbaJdblwYs28z3chM7QkfCGMSM29JWR1fSwPH18WyAA84YtxfPD8bfb1Exwo0CRw1RLRScn 6aJhsZJFLKyVeaPO1eequEsFQurRhLyAfgaH9iazmOVZZmxsGiNRJkQv4YnM2rZYi+4vWnxN 1ebHf4S1puN0xzQsULhG3rUyV2uIsqBFtlxZ8/r9MwOJ2mvyTXHzHdJBViOalZAUo7VFt3Fb aNkR5OR65eTL0ViQiRgFfPDBgkFCSlaxZvc7qSOcrhol160bK87qn0SbYLfplwiXZY/b/+ez 0zBtIt+uhZJ38HnOLWdda/8kuLX3qhGL5aNz1AeqcE5TW4D8v9ndYeAXFhQI7kbOhr0ruUpA udREH98EmVJsADuq0RBcIEkojnme4wVDoFt1EG93YOnqMuif76YGEl3iv9tYcESEeLNruDN6 LDbE8blkR3151tdg8IkgREJ+dK+q0p9UsGfdd+H7pni6Jjcxz8mjKCx6wAuzvArA0Ciq+Scg hfIgoiYQegZjh2vF2lCUzWWatXJoy7IzeAB5LDl/E9vz72cVD8CwQZoEx4PCsHslVpW6A/6U NRAz6ShU77jkoYoI4hoGC7qZcwy84mmJqRygFnb8dOjHI1KxqQARAQABzSZUb20gTGVuZGFj a3kgPHRob21hcy5sZW5kYWNreUBhbWQuY29tPsLBmQQTAQoAQwIbIwcLCQgHAwIBBhUIAgkK CwQWAgMBAh4BAheAAhkBFiEE3Vil58OMFCw3iBv13v+a5E8wTVMFAmkbaKgFCRZQah8ACgkQ 3v+a5E8wTVPFyg//UYANiuHfxxJET8D6p/vIV0xYcf1SXCG78M+5amqcE/4cCIJWyAT3A1nP zwyQIaIjUlGsXQtNgC1uVteCnMNJCjVQm0nLlJ9IVtXxzRg0QKjuSdZxuL5jrIon4xW9hTJR 94i2v3Fx5UWyP2TB6qZOcB0jgh0l01GHF9/DVJbmQlpvQB4Z1uNv09Q7En6EXi28TSv0Ffd1 p8vKqxwz7CMeAeZpn5i7s1QE/mQtdkyAmhuGD12tNbWzFamrDD1Kq3Em4TIFko0+k5+oQAAf JFaZc1c0D4GtXwvv4y+ssI0eZuOBXapUHeNNVf3JGuF6ZPLNPAe5gMQrmsJinEArVYRQCuDA BZakbKw9YJpGhnSVeCl2zSHcVgXuDs4J2ONxdsGynYv5cjPb4XTYPaE1CZH7Vy1tqma8eErG rcCyP1seloaC1UQcp8UDAyEaBjh3EqvTvgl+SppHz3im0gPJgR9km95BA8iGx9zqDuceATBc +A007+XxdFIsifMGlus0DKPmNAJaLkEEUMedBBxH3bwQ+z8tmWHisCZQJpUeGkwttD1LK/xn KRnu8AQpSJBB2oKAX1VtLRn8zLQdGmshxvsLUkKdrNE6NddhhfULqufNBqul0rrHGDdKdTLr cK5o2dsf9WlC4dHU2PiXP7RCjs1E5Ke0ycShDbDY5Zeep/yhNWLOwU0EVo1liQEQAL7ybY01 hvEg6pOh2G1Q+/ZWmyii8xhQ0sPjvEXWb5MWvIh7RxD9V5Zv144EtbIABtR0Tws7xDObe7bb r9nlSxZPur+JDsFmtywgkd778G0nDt3i7szqzcQPOcR03U7XPDTBJXDpNwVV+L8xvx5gsr2I bhiBQd9iX8kap5k3I6wfBSZm1ZgWGQb2mbiuqODPzfzNdKr/MCtxWEsWOAf/ClFcyr+c/Eh2 +gXgC5Keh2ZIb/xO+1CrTC3Sg9l9Hs5DG3CplCbVKWmaL1y7mdCiSt2b/dXE0K1nJR9ZyRGO lfwZw1aFPHT+Ay5p6rZGzadvu7ypBoTwp62R1o456js7CyIg81O61ojiDXLUGxZN/BEYNDC9 n9q1PyfMrD42LtvOP6ZRtBeSPEH5G/5pIt4FVit0Y4wTrpG7mjBM06kHd6V+pflB8GRxTq5M 7mzLFjILUl9/BJjzYBzesspbeoT/G7e5JqbiLWXFYOeg6XJ/iOCMLdd9RL46JXYJsBZnjZD8 Rn6KVO7pqs5J9K/nJDVyCdf8JnYD5Rq6OOmgP/zDnbSUSOZWrHQWQ8v3Ef665jpoXNq+Zyob pfbeihuWfBhprWUk0P/m+cnR2qeE4yXYl4qCcWAkRyGRu2zgIwXAOXCHTqy9TW10LGq1+04+ LmJHwpAABSLtr7Jgh4erWXi9mFoRABEBAAHCwXwEGAEKACYCGwwWIQTdWKXnw4wULDeIG/Xe /5rkTzBNUwUCaRto5wUJFlBqXgAKCRDe/5rkTzBNUw4/EAClG106SeHXiJ+ka6aeHysDNVgZ 8pUbB2f8dWI7kzD5AZ5kLENnsi1MzJRYBwtg/vVVorZh6tavUwcIvsao+TnV57gXAWr6sKIc xyipxRVEXmHts22I6vL1DirLAoOLAwWilkM+JzbVE3MMvC+cCVnMzzchrMYDTqn1mjCCwiIe u5oop+K/RgeHYPsraumyA9/kj8iazrLM+lORukCNM7+wlRClcY8TGX+VllANym9B6FMxsJ5z Q7JeeXIgyGlcBRME+m3g40HfIl+zM674gjv2Lk+KjS759KlX27mQfgnAPX4tnjLcmpSQJ77I Qg+Azi/Qloiw7L/WsmxEO5ureFgGIYDQQUeM1Qnk76K5Z3Nm8MLHtjw3Q7kXHrbYn7tfWh4B 7w5Lwh6NoF88AGpUrosARVvIAd93oo0B9p40Or4c5Jao1qqsmmCCD0dl7WTJCboYTa2OWd99 oxS7ujw2t1WMPD0cmriyeaFZnT5cjGbhkA+uQGuT0dMQJdLqW3HRwWxyiGU/jZUFjHGFmUrj qFAgP+x+ODm6/SYn0LE0VLbYuEGfyx5XcdNnSvww1NLUxSvuShcJMII0bSgP3+KJtFqrUx9z l+/NCGvn/wMy6NpYUpRSOmsqVv0N71LbtXnHRrJ42LzWiRW2I5IWsb1TfdMAyVToHPNaEb0i WiyqywZI5g== In-Reply-To: <20260707150033.2364758-1-tycho@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH2PR19CA0021.namprd19.prod.outlook.com (2603:10b6:610:4d::31) To SN7PR12MB8131.namprd12.prod.outlook.com (2603:10b6:806:32d::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN7PR12MB8131:EE_|CY8PR12MB8337:EE_ X-MS-Office365-Filtering-Correlation-Id: 28fdff0d-05da-4182-1213-08dedc41d5f2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|23010399003|376014|22082099003|18002099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: XGdyFsxnlG4QcyEwPPDjcBQNCpLmKizTzfmsarmPKwOLlOBDs+YaR9G7tXJPWCzXFQgBOKPzyukAjDfj83nmVUiT0CPFIcmKknbW+P439BhlJuOH2xllOLWjw4s3x4S9IFuo3WQAbHdoml/5+udKr2p9uq8h8sp+bFqgWQa2cytsDyDADQllplDGJWwTokDDLSRYZwUHmM1uEitORaXokzP/WpneMGTq5fUqACelDkorS9lMURn91w1xjglRGdtnO+5k3f/nDLy8qsPWXwzut6i2pKkpxssJ51GfNZBsMc37oSNwigq+/AIxlzOrWii8V5zrUXOILQVgUz2KCL2I6m9Yb1ioiCJNlQR3omG7Za3Cr/SBUrpOCmnR9bMaG3fhjoiF9XEoOuZCZ95K128lnu1ORsv9f1XQj13ubpdcMwoApziVS1P8T6+nxxHzKpLmEb753BL6ZoRurvQXeuleLHj+Ew81ft9/rMWUiY4fsVKFXYPXujk6Xgqu3KB7MIoa11yS5hO1tpHlG/u+fEr5GddgGXTK2n1wAdy5quydYzRlnGwOHHogaP2R9TFbGskpVNz7igV0etWdtuSsWWdBmlaCO8kqEDof7zDZFI3DqWC2pqEH+QI29E5rAiRGlPuNVVBYR0rBGl6e2FI+NIs4S7G7CkuiFIOma0kFe909vhA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN7PR12MB8131.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(23010399003)(376014)(22082099003)(18002099003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U3RGb3p6V0w1aUpIN2txNTc5cUdVWkZJQyt6U3VCcktUZzFxSXFITmJHaE5Y?= =?utf-8?B?RnIrNEROYkI5Vlc1ZVh6cHdLQW5qTHhGd2pzaWJwQTdqTjlsYkNHTFpnUmVm?= =?utf-8?B?VThuZk9MNFc0bEVSaFlTVHFyWnJNNkFSN3JKRnRLcWRVa2U1dDRyOHAwTmJs?= =?utf-8?B?MTFCZ05mekpBakRrcEJ1Ri8vb0svRngyODZGT3NsL284NWtOOW1EZjNDdlFk?= =?utf-8?B?YjJheGZBR01RL0J6V0JlM2hIN0hsZDBYdjVoY21URzQrTCsyaHFMd2d3Sllh?= =?utf-8?B?Q2tIWlhyaDl5YjhENXE4b1FIWU00K3VBdFpnaTNqUjhHWGRsUWFuYkY0cTlR?= =?utf-8?B?N3FDMVlOeS9mY1hCdisxUXZ0azhqSDRDSlJrVkxlVUl3MGcvZk5tVVdvcENw?= =?utf-8?B?NVBmeEx5Qkova2RyYk0waVV4M0xWTDUxZGxiMUsxOHBYRUhDZlBBTlVXb1JD?= =?utf-8?B?dkc0UFBwU3NVeVRzNSt0R1YwS2w5aWlmL0RGSERpNlVJTUo5UFBJc2hXQ2xD?= =?utf-8?B?bmtsclB5czBsWUFLVVFOdVBOYzNQRHg3cEtKZVdsTnBkVVgxQnp2WHhSRjNT?= =?utf-8?B?U1pQYUtpckxHTUpuWHdBZ1J5YWlENnNHNWlFTHJDb3RGY3BRb0NVZ3RuR2I2?= =?utf-8?B?Sk92MmJpT0pydWFJZWpnSVdWb05yM1FDejQ0eXFiSlpIVzFLbW5GMlQrZlBI?= =?utf-8?B?TnFoUlFlNmtSN1ArcDVrMVNNZTlmQWRnWnFTcndFbmx2Wi9pcTRFSzFuZFRz?= =?utf-8?B?VkhRdmt3bVEydk5Eb2JpRXV6bm85OXZhRUZ1NGszcFArVGxnWVNpaTVMd2Fx?= =?utf-8?B?bTJsd2wvSmk1aGRmVVp4WUFmOCtsRk8zWHJIZW8zZHloSnU5eWJrODQyUEc4?= =?utf-8?B?d2JST1dxTTh6MytGQVdSY1UzUE9nc1ovSVFvL0VLbVh0RVpmVlQ4cGdMeXhP?= =?utf-8?B?QzRXcWlnc2xwUWh2OEFNN3lNYXlpTWtYMldyaHZvN0RGOXhablorRnBsS0lj?= =?utf-8?B?NGJucWo0d2NuTTM3NVRYLzVNWGJsREM2b3ZDcmdrdjJKOXhyNWUxbUh3Q1B6?= =?utf-8?B?cDVtOW0xNG56eUtrNzM0V1hlcDFCeW1hQmZzblc3MDZjUTVvRHc4OCtyNTVa?= =?utf-8?B?ZDVYdWZ5Z0QvbjlRYnFHakpTWmJpZFp5elpBMGtNUjh0LzB1dkhHWHJaZ04x?= =?utf-8?B?WXdnR2ozQVhpdERyN05XdUhlUGV6NVRQZ3phUks3aDUxN3dtcG1uV1dydTdp?= =?utf-8?B?eFZpVHQxb2tBWVcrbWhIRE53S2pvMXAycENvdkRSelVLQ2FDN3NYaGQzUndL?= =?utf-8?B?SjZyY1NGSWxpakZOdEpUNldxdFAxK0p2UkFFSk1uSzZWODNXZVhYeXZvL3gv?= =?utf-8?B?Z1pxL0R0RXBOK0JYU3p5aTFqYVZDWGwxa0M0WlVOZzdTTHJiR2M2cFB1MDZQ?= =?utf-8?B?dXJPbFBWSkR1NmF2NXYzNzB4cEpMMG96NTIrQ0VXODJsVktQN0VIMEdRZTcw?= =?utf-8?B?NnNIcStGNExmMVEyYzU0cTNRV3ZBVStiSmNDWDNCcGJWVGlIQXg1U01hWnBy?= =?utf-8?B?cDZxeTZXOUxNdUxVUU5YZTVwbnA5WVRvU0pzaFhkZk1uMG5lZVZrRk82RlJm?= =?utf-8?B?L2I5dWE2by8wZ2R5TW1kV1NDcEw3ajJ5MHlrY2lHTXhYY1B6aU0rWHo2Uk5p?= =?utf-8?B?anZ2NG9LMnR6VkdpRWxVZ1ZJclQ4Rk9HOWtqSFZQVUxRVTdXWlhKR0pIejY3?= =?utf-8?B?RFp1YzRwOU81cFpKNmlDaHRQamNWV0poRVZZWmFYeGsvUkN2c2psT2tTaHBw?= =?utf-8?B?bGdoUTlyRG9lTCt2RnpwQXRYS1VFOG5qUytRSmdDYzF5S3JobXlsWkVxNjdE?= =?utf-8?B?aDM2OHEzUkZVTGFRaGZFSzBtV01KQW50UjdMZnZLeUNpRkZjWmhvZ3ZYeFhu?= =?utf-8?B?SDY3VkhnSk1nbXVqMVc1a2daUExBTjRwaThFTlliSGtWRlpFTENGMWZyRnQ5?= =?utf-8?B?L2Vzc1VIRkZzZzVqOFZHaDFBL2RxVElKTXAyKzlpRkJzaFg0dFhZTHd1Ym9u?= =?utf-8?B?SzNmT3B1cGU3cXRHRHNrWTVKVGdPZVJnaTZvbFZBM0h3VFVFemVwRnFhWjl0?= =?utf-8?B?VmhnYVBZd2d5QjB6YW9XZlVjZGRSdDlGWkNjYWIwR3lNemgrZDY3V2JjbHFh?= =?utf-8?B?RnBwRVpkTDU5Mk1hRDVmclhzTXVTVTNCc055TzFhcHRVb3BCMXNZWVc5bWV5?= =?utf-8?B?bjJoNkliakFCVGJUSjArU0U1cEhJcWt1Ni9yTmdlckVlditON1ZiWlR4NUNZ?= =?utf-8?B?R0FkeThUdmZYQS83dHYvNCtBaWx1S2VxQjFVa0hadEY2UEdJNUpJQT09?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28fdff0d-05da-4182-1213-08dedc41d5f2 X-MS-Exchange-CrossTenant-AuthSource: SN7PR12MB8131.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2026 16:07:25.7157 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wOEIOoSCsvnmOE/smUae6c8hq1unDNDgy3ABcUMPMlmdPqV0MBlXPDD5TrDgIv0VhROFM0kwAS3eb7g5q2qP3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8337 On 7/7/26 10:00, Tycho Andersen wrote: > From: "Tycho Andersen (AMD)" > > This reverts commit 99cf1fb58e68 ("x86/virt/sev: Drop WBINVD before setting > MSR_AMD64_SYSCFG_SNP_EN"). > > Section 8.8 of the SNP spec says: > > Before invoking SNP_INIT_EX with INIT_RMP set to 1, software must > ensure that no CPUs contain dirty cache lines for the memory containing > the RMP. > > Cachelines can be moved from cache to cache in a dirty state. The > wbinvd_on_all_cpus() before SNP_INIT_EX flushes the caches for each cpu, > but if the IPIs for WBINVD race with this dirty cacheline movement, it is > possible that they may not get flushed violating the firmware requirement. > > Doing wbinvd_on_all_cpus() before setting SNPEn is safer since the RMP > table is not yet in use. > > [ Heroically bisected by Srikanth. ] > Reported-by: Srikanth Aithal > Tested-by: Srikanth Aithal > Fixes: 99cf1fb58e68 ("x86/virt/sev: Drop WBINVD before setting MSR_AMD64_SYSCFG_SNP_EN") > Signed-off-by: Tycho Andersen (AMD) Reviewed-by: Tom Lendacky > --- > arch/x86/virt/svm/sev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/x86/virt/svm/sev.c b/arch/x86/virt/svm/sev.c > index 8bcdce98f6dc..cff285d8ad8e 100644 > --- a/arch/x86/virt/svm/sev.c > +++ b/arch/x86/virt/svm/sev.c > @@ -536,6 +536,8 @@ int snp_prepare(void) > goto unlock; > } > > + wbinvd_on_all_cpus(); > + > /* > * MtrrFixDramModEn is not shared between threads on a core, > * therefore it must be set on all CPUs prior to enabling SNP. > > base-commit: aa6d9def48ea424a50c21de90ebe609c383cb05d