From: "Jürgen Groß" <jgross@suse.com>
To: Paul Durrant <pdurrant@amazon.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v2 1/2] xen/xenbus: reference count registered modules
Date: Fri, 29 Nov 2019 16:46:15 +0100 [thread overview]
Message-ID: <82ff3fdf-b6f6-656d-4638-3b9f0a264fab@suse.com> (raw)
In-Reply-To: <20191129134306.2738-2-pdurrant@amazon.com>
On 29.11.19 14:43, Paul Durrant wrote:
> To prevent a module being removed whilst attached to a frontend, and
> hence xenbus calling into potentially invalid text, take a reference on
> the module before calling the probe() method (dropping it if unsuccessful)
> and drop the reference after returning from the remove() method.
>
> NOTE: This allows the ad-hoc reference counting in xen-netback to be
> removed. This will be done in a subsequent patch.
>
> Suggested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Paul Durrant <pdurrant@amazon.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
next prev parent reply other threads:[~2019-11-29 15:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 13:43 [PATCH v2 0/2] allow xen-blkback to be cleanly unloaded Paul Durrant
2019-11-29 13:43 ` [PATCH v2 1/2] xen/xenbus: reference count registered modules Paul Durrant
2019-11-29 15:46 ` Jürgen Groß [this message]
2019-11-29 16:00 ` Jan Beulich
2019-11-29 16:08 ` Durrant, Paul
2019-11-29 13:43 ` [PATCH v2 2/2] block/xen-blkback: allow module to be cleanly unloaded Paul Durrant
2019-11-29 15:00 ` Roger Pau Monné
2019-11-29 15:02 ` Durrant, Paul
2019-11-29 15:07 ` Roger Pau Monné
2019-11-29 15:45 ` Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82ff3fdf-b6f6-656d-4638-3b9f0a264fab@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jbeulich@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pdurrant@amazon.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox