The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Naman Jain <namjain@linux.microsoft.com>
To: Abhishek Tiwari <abhitiwari@linux.microsoft.com>,
	abhitiwari@microsoft.com, kys@microsoft.com,
	haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com,
	linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
	ssengar@microsoft.com
Subject: Re: [PATCH] x86/hyperv: Cosmetic changes for hv_utils_transport.c
Date: Wed, 30 Jul 2025 16:38:33 +0530	[thread overview]
Message-ID: <83070bd2-209a-4143-9efa-0a67f489563f@linux.microsoft.com> (raw)
In-Reply-To: <1753871840-23636-1-git-send-email-abhitiwari@linux.microsoft.com>



On 7/30/2025 4:07 PM, Abhishek Tiwari wrote:
> Fix issues reported by checkpatch.pl script for hv_utils_transport.c file
> - Update pr_warn() calls to use __func__ for consistent logging context.
> - else should follow close brace '}'
> 
> No functional changes intended.
> 
> Signed-off-by: Abhishek Tiwari <abhitiwari@linux.microsoft.com>

Please use a different prefix for Subject.
Replace "x86/hyperv:" with "Drivers: hv: util:"

We generally follow the naming practice used for a file, which can be
seen in git log <file_path>.

Rest LGTM. Post above change:
Reviewed-by: Naman Jain <namjain@linux.microsoft.com>

Regards,
Naman


  reply	other threads:[~2025-07-30 11:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-30 10:37 [PATCH] x86/hyperv: Cosmetic changes for hv_utils_transport.c Abhishek Tiwari
2025-07-30 11:08 ` Naman Jain [this message]
2025-07-30 12:48   ` Abhishek Tiwari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83070bd2-209a-4143-9efa-0a67f489563f@linux.microsoft.com \
    --to=namjain@linux.microsoft.com \
    --cc=abhitiwari@linux.microsoft.com \
    --cc=abhitiwari@microsoft.com \
    --cc=decui@microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ssengar@microsoft.com \
    --cc=wei.liu@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox