From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD81DC2D0A3 for ; Thu, 29 Oct 2020 14:52:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6CE3920738 for ; Thu, 29 Oct 2020 14:52:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mlsT+ygO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727214AbgJ2OwF (ORCPT ); Thu, 29 Oct 2020 10:52:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726166AbgJ2OwF (ORCPT ); Thu, 29 Oct 2020 10:52:05 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5ADAFC0613CF for ; Thu, 29 Oct 2020 07:52:03 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id a72so113290wme.5 for ; Thu, 29 Oct 2020 07:52:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=AFFmqs9Jzg2CBvGq0/RAb9bueZj0QRM93cJN24vLo/g=; b=mlsT+ygOuRPeLbbg2/X3s0BssdBWUrtOU5Z5tMSj9B398yqQ4PztYfVs0HGQ+Cms+H Eh1p5UGg1mgW9dAeOQCBw9pdm92eVwJ0fTjUcoovc8r3aPouGlr6OuB5frC3bfg5mecV Tn1OqPn0nrqtEP2C10WfInAaNFspCnaUhDRw3Dw4IgOtAsb91KiRknOfMgW9w8z7I4bZ xG1UJ5GibCIDhqGDXPTjd4pXKeRqcKK7gLhHuBh97Tm699zU4tRIAELTZtCRjLI/Vdnz 27wFxFHpOGdRIizXgu7lRAuhbZogWEXqkKUKZQ3Gijok04lY86YYVlROm9s5yaP8XM4y hA5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AFFmqs9Jzg2CBvGq0/RAb9bueZj0QRM93cJN24vLo/g=; b=SaTcfgC8OggomZpausvcbJZRI1lwwdwH0te9P3Uj4nF8rgLPaR4gtNfyABcRO80Sw4 WTJuX/AJHEttMPtrz14i6pXj9LQSw9x5yvEWJwiFoqwDPLl00vb8we6+OgS1X475r0ld NOD5OiJ6iSVsRIDoJH8/jUXmyVcgp9v7clM/Blb3uCysqd5dSiQ3jdEeBstlGQuwnnni PVl8YHG3rP7arWV97cgF0K2Q3pO6Zu1q+/ck3r87hgrpXnOBI+wG4qwq8Te+wNqbE4ib Z5nXb4DvAgK3oxsTeUnhehSJpd9gph+eBe4OGDcidieIi7xDAQUUJ4Ying17W494wvyY qwXw== X-Gm-Message-State: AOAM532SChHIBWxX4W1DPIEKWdOiO/LoBqrAxrvrGAT6xC4v0qDk32rA y9XBER5j16RnBQLckY3RbYk= X-Google-Smtp-Source: ABdhPJyRmXDMMlqLf2r5d2iixnFqEChax1O6Zs+WOLgjm/1pylu/Ki+RiI0wEZOrsLCDOkPS1LGkcw== X-Received: by 2002:a1c:e006:: with SMTP id x6mr173380wmg.107.1603983122020; Thu, 29 Oct 2020 07:52:02 -0700 (PDT) Received: from ziggy.stardust ([213.195.117.206]) by smtp.gmail.com with ESMTPSA id x64sm140151wmg.33.2020.10.29.07.52.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Oct 2020 07:52:01 -0700 (PDT) Subject: Re: [PATCH v3 15/16] soc: mediatek: pm-domains: Add default power off flag To: Weiyi Lu Cc: Enric Balletbo i Serra , linux-kernel@vger.kernel.org, drinkcat@chromium.org, hsinyi@chromium.org, Collabora Kernel ML , fparent@baylibre.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20201026175526.2915399-1-enric.balletbo@collabora.com> <20201026175526.2915399-16-enric.balletbo@collabora.com> <05be2a94-d6e6-36e5-2c14-6d971e4a7677@gmail.com> <1603797517.25228.3.camel@mtksdaap41> From: Matthias Brugger Message-ID: <83197162-6bfc-b861-653e-4fd21035b5ae@gmail.com> Date: Thu, 29 Oct 2020 15:51:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <1603797517.25228.3.camel@mtksdaap41> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/10/2020 12:18, Weiyi Lu wrote: > On Tue, 2020-10-27 at 11:53 +0100, Matthias Brugger wrote: >> >> On 26/10/2020 18:55, Enric Balletbo i Serra wrote: >>> From: Weiyi Lu >>> >>> For some power domain, like conn on MT8192, it should be default OFF. >>> Because the power on/off control relies the function of connectivity chip >>> and its firmware. And if project choose other chip vendor solution, >>> those necessary connectivity functions will not provided. >>> >>> Signed-off-by: Weiyi Lu >>> Signed-off-by: Enric Balletbo i Serra >>> --- >>> >>> Changes in v3: None >>> Changes in v2: None >>> >>> drivers/soc/mediatek/mtk-pm-domains.c | 23 +++++++++++++++++------ >>> drivers/soc/mediatek/mtk-pm-domains.h | 1 + >>> 2 files changed, 18 insertions(+), 6 deletions(-) >>> >>> diff --git a/drivers/soc/mediatek/mtk-pm-domains.c b/drivers/soc/mediatek/mtk-pm-domains.c >>> index 63993076a544..fe0e955076a0 100644 >>> --- a/drivers/soc/mediatek/mtk-pm-domains.c >>> +++ b/drivers/soc/mediatek/mtk-pm-domains.c >>> @@ -378,10 +378,16 @@ generic_pm_domain *scpsys_add_one_domain(struct scpsys *scpsys, struct device_no >>> * software. The unused domains will be switched off during >>> * late_init time. >>> */ >>> - ret = scpsys_power_on(&pd->genpd); >>> - if (ret < 0) { >>> - dev_err(scpsys->dev, "%pOF: failed to power on domain: %d\n", node, ret); >>> - goto err_unprepare_clocks; >>> + if (MTK_SCPD_CAPS(pd, MTK_SCPD_KEEP_DEFAULT_OFF)) { >>> + if (scpsys_domain_is_on(pd)) >>> + dev_warn(scpsys->dev, >>> + "%pOF: A default off power domain has been ON\n", node); >>> + } else { >>> + ret = scpsys_power_on(&pd->genpd); >>> + if (ret < 0) { >>> + dev_err(scpsys->dev, "%pOF: failed to power on domain: %d\n", node, ret); >>> + goto err_unprepare_clocks; >>> + } >>> } >>> >>> if (scpsys->domains[id]) { >>> @@ -395,7 +401,11 @@ generic_pm_domain *scpsys_add_one_domain(struct scpsys *scpsys, struct device_no >>> pd->genpd.power_off = scpsys_power_off; >>> pd->genpd.power_on = scpsys_power_on; >>> >>> - pm_genpd_init(&pd->genpd, NULL, false); >>> + if (MTK_SCPD_CAPS(pd, MTK_SCPD_KEEP_DEFAULT_OFF)) >>> + pm_genpd_init(&pd->genpd, NULL, true); >>> + else >>> + pm_genpd_init(&pd->genpd, NULL, false); >>> + >>> scpsys->domains[id] = &pd->genpd; >>> >>> return scpsys->pd_data.domains[id]; >>> @@ -478,7 +488,8 @@ static void scpsys_remove_one_domain(struct scpsys_domain *pd) >>> "failed to remove domain '%s' : %d - state may be inconsistent\n", >>> pd->genpd.name, ret); >>> >>> - scpsys_power_off(&pd->genpd); >>> + if (!MTK_SCPD_CAPS(pd, MTK_SCPD_KEEP_DEFAULT_OFF)) >>> + scpsys_power_off(&pd->genpd); >> >> OK, so you merged Weiyi's patches in this series :) >> >> So same comment here: Does it really hurt if we turn-off a already turned-off >> power domain? Or can we get rid of this check? >> > > We do need this check here. If you try to turn-off this power domain, > you might make the clock or regulator reference count unbalanced. > Correct. Could we check via scpsys_domain_is_on() instead? I'd like to avoid MTK_SCPD_KEEP_DEFAULT_OFF use here. Regards, Matthias >> Regards, >> Matthias >> >>> >>> clk_bulk_unprepare(pd->num_clks, pd->clks); >>> clk_bulk_put(pd->num_clks, pd->clks); >>> diff --git a/drivers/soc/mediatek/mtk-pm-domains.h b/drivers/soc/mediatek/mtk-pm-domains.h >>> index 2ad213be84a5..0fa6a938b40c 100644 >>> --- a/drivers/soc/mediatek/mtk-pm-domains.h >>> +++ b/drivers/soc/mediatek/mtk-pm-domains.h >>> @@ -6,6 +6,7 @@ >>> #define MTK_SCPD_ACTIVE_WAKEUP BIT(0) >>> #define MTK_SCPD_FWAIT_SRAM BIT(1) >>> #define MTK_SCPD_SRAM_ISO BIT(2) >>> +#define MTK_SCPD_KEEP_DEFAULT_OFF BIT(3) >>> #define MTK_SCPD_CAPS(_scpd, _x) ((_scpd)->data->caps & (_x)) >>> >>> #define SPM_VDE_PWR_CON 0x0210 >>> >