From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754411AbcAHJWS (ORCPT ); Fri, 8 Jan 2016 04:22:18 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:60888 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753404AbcAHJWN (ORCPT ); Fri, 8 Jan 2016 04:22:13 -0500 From: Arnd Bergmann To: Yury Norov Cc: catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, pinskia@gmail.com, Prasun.Kapoor@caviumnetworks.com, schwab@suse.de, Nathan_Lynch@mentor.com, agraf@suse.de, klimov.linux@gmail.com, broonie@kernel.org, jan.dakinevich@gmail.com, ddaney.cavm@gmail.com, bamvor.zhangjian@huawei.com, philipp.tomsich@theobroma-systems.com, joseph@codesourcery.com, christoph.muellner@theobroma-systems.com, Andrew Pinski , Andrew Pinski Subject: Re: [PATCH v6 14/21] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Date: Fri, 08 Jan 2016 10:21:06 +0100 Message-ID: <8354919.jOyEk0znB5@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1452209679-19445-15-git-send-email-ynorov@caviumnetworks.com> References: <1452209679-19445-1-git-send-email-ynorov@caviumnetworks.com> <1452209679-19445-15-git-send-email-ynorov@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:Gom9kXxoyeqIpapg39r60ShhwTiZh9q9eyQ9P8/L6IW0+9bgPWn UyfeqyvXdywBuOFeOGka4puebECSkB0rHPawrbTJggFsndrBP2LfUFYOGWqizgLM3/GVrTe XD5cVlJ/fF3uyDaFvH8svO5nZCnipv4ZpfSXHVILEy2d1QOYwtZkgqdGFF9MfpCCxkuaFwQ JAy94rW1mjN10H1c+Ojmw== X-UI-Out-Filterresults: notjunk:1;V01:K0:81InsvbyxlU=:oS7Q9B3qM2WUEtlF/A3PlN zuLqRrbiJmg1oWwOtv/ePujnMEtLSOo8Zh3RfUV7Qn3k922/TmCfM4Isj2nzcSMVYJCREue3L wGc9P5sx3ZCNSVhdYKXXuiBfIkQ0ouXwh5zL9UXYVcb88INUjdiMErjN/KCQVavinuqHRijvr jT5h0OLAHBT/l4jxkoLiyNlwr7kivp3zd9q3nz/9Wa/zVkZ2/lPlmRtup5S2TyKh13s4ylpg0 fq+835yn2+3rI6jMx9buT6V/+MaW5THjaP8q+ZTfB9/zdqZiSERGBLpCLuAAOqmKmtKqEF9HA eG2WTRZ/zbE7R1/XdxW39/rqpBQ10YaYN9PB4sYYqXJrVdwDmrKkVZgbg+/kma2kw/xHljuBC 8mzgcIom859a8bP73jtuV02iUcOylfXtOXuraKis2KkVf5ZE+nM3DItadNzoItFB8DOPCWiwR yJiBLivxoFN35cseXAUbGjhpSYJgrWfD+js/SBYeES6xAWlr9PO1cj30NqtGuyEaVDtJVEa6L SIU0CxF4oQsulC71/0IlR1KVkkUhiXl6FL61dVntDwayLFeq048uVgii1qD7ocjxCG+nVnaAz b0zskqiVZgmU8iSleeqM4evtsLsaktp/fI6UE2ifrhr1q3WFqWvW/8ZaZ2XeAKjX6Hmz8IkX1 YCHvFeYb06aDJBT/f1PIDb/k5JRjjTYTlVsGEZuEETG/rakhRSNaq0qiQ7k2Mien1ouLvAV/f uBkwH3Lb7quUrKi+U3WQHzVzDyJcNXgSGC1LaA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 08 January 2016 02:34:32 Yury Norov wrote: > @@ -688,6 +692,12 @@ ni_sys: > b ret_fast_syscall > ENDPROC(el0_svc) > > +#ifdef CONFIG_ARM64_ILP32 > +el0_ilp32_svc: > + adrp stbl, sys_call_ilp32_table // load syscall table pointer > + b el0_svc_naked > +#endif Don't we still need some code that clears the top halves of the 32-bit arguments? That thread has taken so many turns now that I'm confused about what we actually need, but I thought we had concluded that your current approach has at some some problems. > +#include > + > +#undef __SYSCALL > +#undef __SC_COMP > +#undef __SC_3264 > +#undef __SC_COMP_3264 The four #undef are not needed, right? Arnd