From: Jeremy Kerr <jk@codeconstruct.com.au>
To: admiyo@os.amperecomputing.com,
Sudeep Holla <sudeep.holla@arm.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
Robert Moore <robert.moore@intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Len Brown <lenb@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Matt Johnston <matt@codeconstruct.com.au>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Huisong Li <lihuisong@huawei.com>
Subject: Re: [PATCH v4 1/3] mctp pcc: Check before sending MCTP PCC response ACK
Date: Thu, 04 Jul 2024 17:40:59 +0800 [thread overview]
Message-ID: <835997d71ae1b68f2eb9f1617dce126f75783aae.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20240702225845.322234-2-admiyo@os.amperecomputing.com>
Hi Adam,
> +static void check_and_ack(struct pcc_chan_info *pchan, struct mbox_chan *chan)
> +{
> + struct pcc_extended_type_hdr pcc_hdr;
> +
> + if (pchan->type != ACPI_PCCT_TYPE_EXT_PCC_SLAVE_SUBSPACE)
> + return;
> + memcpy_fromio(&pcc_hdr, pchan->shmem_base_addr,
> + sizeof(struct pcc_extended_type_hdr));
> + /*
> + * The PCC slave subspace channel needs to set the command complete bit
> + * and ring doorbell after processing message.
> + *
> + * The PCC master subspace channel clears chan_in_use to free channel.
> + */
> + if (!!le32_to_cpup(&pcc_hdr.flags) & PCC_ACK_FLAG_MASK)
This should be:
if (!!(le32_to_cpup(&pcc_hdr.flags) & PCC_ACK_FLAG_MASK))
- otherwise you're bitwise testing the result of the '!!'.
Cheers,
Jeremy
next prev parent reply other threads:[~2024-07-04 9:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 22:58 [PATCH v4 0/3] MCTP over PCC admiyo
2024-07-02 22:58 ` [PATCH v4 1/3] mctp pcc: Check before sending MCTP PCC response ACK admiyo
2024-07-03 19:52 ` Simon Horman
2024-07-04 2:44 ` kernel test robot
2024-07-04 8:53 ` kernel test robot
2024-07-04 9:40 ` Jeremy Kerr [this message]
2024-07-02 22:58 ` [PATCH v4 2/3] mctp pcc: Allow PCC Data Type in MCTP resource admiyo
2024-07-02 22:58 ` [PATCH v4 3/3] mctp pcc: Implement MCTP over PCC Transport admiyo
2024-07-03 19:53 ` Simon Horman
2024-07-04 5:43 ` kernel test robot
2024-07-04 6:08 ` kernel test robot
2024-07-04 10:23 ` Jeremy Kerr
2024-07-08 22:16 ` Adam Young
2024-07-11 16:57 ` [PATCH v4 0/3] MCTP over PCC Dan Williams
2024-07-15 18:21 ` Adam Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835997d71ae1b68f2eb9f1617dce126f75783aae.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=Jonathan.Cameron@huawei.com \
--cc=admiyo@os.amperecomputing.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jassisinghbrar@gmail.com \
--cc=kuba@kernel.org \
--cc=lenb@kernel.org \
--cc=lihuisong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox