Re: [PATCH v2 2/2] arm64: dts: qcom: milos: Add IMEM node

Krzysztof Kozlowski
2026-04-08T08:36:39Z

On 08/04/2026 10:11, Luca Weiss wrote:
>>> };
>>>
>>> + sram@14680000 {
>>> + compatible = "qcom,milos-imem", "mmio-sram";
>>> + reg = <0x0 0x14680000 0x0 0x2c000>;
>>> + ranges = <0 0 0x14680000 0x2c000>;
>>
>> Use hex here as well.
>
> Will do: ranges = <0x0 0x0 0x14680000 0x2c000>;
>
> Do you also have a comment around the name of the subnodes? Do you think
> they're okay as-is, or should they be changed?

I think they follow what the binding expects, so not much to discuss here :)

Best regards,
Krzysztof