From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DE6FC761AF for ; Thu, 30 Mar 2023 14:40:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232118AbjC3Okq (ORCPT ); Thu, 30 Mar 2023 10:40:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232184AbjC3Okk (ORCPT ); Thu, 30 Mar 2023 10:40:40 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BB09213A for ; Thu, 30 Mar 2023 07:39:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680187195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=O3V/Opjj7Xto80R0YuRGPZTCgbXp6rtl0lkxbOZukAg=; b=NiRhe7ZKmAhUyvbq4XQ95uD8hggzrf9/ePX3MbC5Ytp48t36yfKrF73mGtheHLJsgVn9mY 7B2yt32C8zz1KPi87biTahY9LgVzh4qJC6y9srpjJB3pte2zjdqcmY+ZALVY1i+zXBNyYr DNeu2wG4O7TIvEUMmhvk+chCHs6gv0U= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-515-E0MKE2P4Mqa-h5CUMt8wSA-1; Thu, 30 Mar 2023 10:39:51 -0400 X-MC-Unique: E0MKE2P4Mqa-h5CUMt8wSA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 510DD884340; Thu, 30 Mar 2023 14:39:50 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 699CEC15BA0; Thu, 30 Mar 2023 14:39:48 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <64259aca22046_21883920890@willemb.c.googlers.com.notmuch> References: <64259aca22046_21883920890@willemb.c.googlers.com.notmuch> <20230329141354.516864-1-dhowells@redhat.com> <20230329141354.516864-17-dhowells@redhat.com> To: Willem de Bruijn Cc: dhowells@redhat.com, Matthew Wilcox , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH v2 16/48] ip, udp: Support MSG_SPLICE_PAGES MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <838853.1680187186.1@warthog.procyon.org.uk> Date: Thu, 30 Mar 2023 15:39:46 +0100 Message-ID: <838854.1680187186@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Willem de Bruijn wrote: > > diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c > > A non-RFC version would require the same for ipv6, of course. I missed the fact that ipv6 had it's own version of __ip_append_data() despite sharing tcp_sendmsg(). Could __ip_append_data() and __ip6_append_data() be shared? I guess that the v6_cork, the flowi6 and the ipcm6_cookie might prevent that. David