From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E43AC43461 for ; Mon, 14 Sep 2020 13:21:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E1DD2075A for ; Mon, 14 Sep 2020 13:21:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="LSd/yCqa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726551AbgINNUS (ORCPT ); Mon, 14 Sep 2020 09:20:18 -0400 Received: from mail29.static.mailgun.info ([104.130.122.29]:35058 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726704AbgINNKK (ORCPT ); Mon, 14 Sep 2020 09:10:10 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1600088993; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=qzjPchJ1lLROgB9pP+RCaQlLLLIEeCxtEGrdUIxmEZU=; b=LSd/yCqadEW8Rj1+0qYYvu8EWOh+x3exSiqPpXubGiCadC+3EP7+kXn/FJ7q2IqNGYybd191 Dx5WgQ6Cqn2I822J/XLHb0oVJStDGnFtYGrAwLOu+WbzbFFBtIKlBL0g/3YBV7ALa8Ml3Azc W7sps6XuYFCuy4cgi8jdI5jITNY= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-west-2.postgun.com with SMTP id 5f5f6b95be06707b342ac16f (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 14 Sep 2020 13:09:41 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D362AC433F0; Mon, 14 Sep 2020 13:09:40 +0000 (UTC) Received: from [192.168.43.98] (unknown [47.8.187.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: akashast) by smtp.codeaurora.org (Postfix) with ESMTPSA id BE9E5C433CA; Mon, 14 Sep 2020 13:09:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BE9E5C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=akashast@codeaurora.org Subject: Re: [PATCH] spi: spi-geni-qcom: Don't wait to start 1st transfer if transmitting To: Douglas Anderson , Mark Brown Cc: swboyd@chromium.org, Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org References: <20200912111716.1.Ied5e843fad0d6b733a1fb8bcfb364dd2fa889eb3@changeid> From: Akash Asthana Message-ID: <838a6074-73e6-a48b-2684-5ea2ebff443a@codeaurora.org> Date: Mon, 14 Sep 2020 18:39:25 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200912111716.1.Ied5e843fad0d6b733a1fb8bcfb364dd2fa889eb3@changeid> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/12/2020 11:47 PM, Douglas Anderson wrote: > If we're sending bytes over SPI, we know the FIFO is empty at the > start of the transfer. There's no reason to wait for the interrupt > telling us to start--we can just start right away. Then if we > transmit everything in one swell foop we don't even need to bother > listening for TX interrupts. > > In a test of "flashrom -p ec -r /tmp/foo.bin" interrupts were reduced > from ~30560 to ~29730, about a 3% savings. > > This patch looks bigger than it is because I moved a few functions > rather than adding a forward declaration. The only actual change to > geni_spi_handle_tx() was to make it return a bool indicating if there > is more to tx. Reviewed-by: Akash Asthana > Signed-off-by: Douglas Anderson -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project