From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932371AbaIILd0 (ORCPT ); Tue, 9 Sep 2014 07:33:26 -0400 Received: from gloria.sntech.de ([95.129.55.99]:47834 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932202AbaIILdY convert rfc822-to-8bit (ORCPT ); Tue, 9 Sep 2014 07:33:24 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Zhang Rui Cc: Caesar Wang , edubezval@gmail.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, huangtao@rock-chips.com, cf@rock-chips.com, dianders@chromium.org, dtor@chromium.org, zyw@rock-chips.com, addy.ke@rock-chips.com, dmitry.torokhov@gmail.com, zhaoyifeng Subject: Re: [PATCH v4 2/4] dt-bindings: document Rockchip thermal Date: Tue, 09 Sep 2014 13:35:31 +0200 Message-ID: <8397565.n78cHk4EtL@diego> User-Agent: KMail/4.12.4 (Linux/3.13-1-amd64; KDE/4.13.3; x86_64; ; ) In-Reply-To: <1410229637.8085.158.camel@rzhang1-toshiba> References: <1409710239-19941-1-git-send-email-caesar.wang@rock-chips.com> <5407BA10.2030402@rock-chips.com> <1410229637.8085.158.camel@rzhang1-toshiba> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, 9. September 2014, 10:27:17 schrieb Zhang Rui: > On Thu, 2014-09-04 at 09:02 +0800, Caesar Wang wrote: > > 在 2014年09月03日 16:07, Heiko Stübner 写道: > > > Am Mittwoch, 3. September 2014, 10:10:37 schrieb Caesar Wang: > > >> This add the necessary binding documentation for the thermal > > >> found on Rockchip SoCs > > >> > > >> Signed-off-by: zhaoyifeng > > >> Signed-off-by: Caesar Wang > > >> --- > > >> > > >> .../devicetree/bindings/thermal/rockchip-thermal.txt | 20 > > >> > > >> ++++++++++++++++++++ 1 file changed, 20 insertions(+) > > >> > > >> create mode 100644 > > >> > > >> Documentation/devicetree/bindings/thermal/rockchip-thermal.txt > > >> > > >> diff --git > > >> a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt > > >> b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt new > > >> file > > >> mode 100644 > > >> index 0000000..1ed4d4c > > >> --- /dev/null > > >> +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt > > >> @@ -0,0 +1,20 @@ > > >> +* Temperature Sensor ADC (TSADC) on rockchip SoCs > > >> + > > >> +Required properties: > > >> +- compatible: "rockchip,rk3288-tsadc" > > >> +- reg: physical base address of the controller and length of memory > > >> mapped > > >> + region. > > >> +- interrupts: The interrupt number to the cpu. The interrupt specifier > > >> format + depends on the interrupt controller. > > >> +- clocks: Must contain an entry for each entry in clock-names. > > >> +- clock-names: Shall be "tsadc" for the converter-clock, and > > >> "apb_pclk" for + the peripheral clock. > > > > > > You're using the passive-temp, critical-temp and force-shut-temp > > > properties in your driver without declaring them here. > > > > frankly,the about are need be declared. but there are 4 types[0] for > > trip in thermal framework, > > there is no force-shut for me. So I want to change it three additional > > properties in [PATCH V4 4/4], > > > > > > [0] > > { > > > > THERMAL_TRIP_CRITICAL, > > THERMAL_TRIP_HOT, > > THERMAL_TRIP_PASSIVE, > > THERMAL_TRIP_ACTIVE, > > > > } > > this sounds reasonable to me. > > > > But more importantly, please use the generic trip-points for this. I > > > guess it shouldn't be a problem to introduce a "forced-shutdown" > > > trippoint [0] for the additional trip-point you have - thermal > > > maintainers, please shout if I'm wrong :-) > > what is the difference between a critical trip point and a > "forced-shutdown" trip point? > Thermal core will do a shutdown in case the critical trip point is > triggered. The forced-shutdown is where the thermal controller is supposed to also do a shutdown in hardware. As you said the thermal core will also shutdown at the critical trip point, I guess we could map Caesar's value like trip-point tsadc critical forced-shutdown (the 120 degrees in patch 4) hot critical (the 100 degrees) ... > > thanks, > rui > > > It's a good option. > > I can send a patch,but I don't know whether the thermal maintainers will > > accept it. > > > > Maybe,they have a better way to suggest it.:-) > > > > > > PS:I will sent a new patch If I still have no received their suggestions > > in two days. > > > > > Heiko > > > > > > > > > [0] in a separate patch, changing > > > - thermal_trip_type enum in include/linux/thermal.h > > > - trip_types mapping in drivers/thermal/of-thermal.c > > > - Documentation/devicetree/bindings/thermal/thermal.txt > > > > > >> + > > >> +Example: > > >> +tsadc: tsadc@ff280000 { > > >> + compatible = "rockchip,rk3288-tsadc"; > > >> + reg = <0xff280000 0x100>; > > >> + interrupts = ; > > >> + clocks = <&cru SCLK_TSADC>, <&cru PCLK_TSADC>; > > >> + clock-names = "tsadc", "apb_pclk"; > > >> +};