From: David Rientjes <rientjes@google.com>
To: Charan Teja Reddy <charante@codeaurora.org>
Cc: akpm@linux-foundation.org, vbabka@suse.cz, nigupta@nvidia.com,
khalid.aziz@oracle.com, vinmenon@codeaurora.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH resend] mm: compaction: optimize proactive compaction deferrals
Date: Sun, 25 Jul 2021 18:47:18 -0700 (PDT) [thread overview]
Message-ID: <83f046a3-5afc-fe6d-40dc-d7aee7b7e398@google.com> (raw)
In-Reply-To: <1626869599-25412-1-git-send-email-charante@codeaurora.org>
On Wed, 21 Jul 2021, Charan Teja Reddy wrote:
> Vlastimil Babka figured out that when fragmentation score didn't go down
> across the proactive compaction i.e. when no progress is made, next wake
> up for proactive compaction is deferred for 1 <<
> COMPACT_MAX_DEFER_SHIFT, i.e. 64 times, with each wakeup interval of
> HPAGE_FRAG_CHECK_INTERVAL_MSEC(=500). In each of this wakeup, it just
> decrement 'proactive_defer' counter and goes sleep i.e. it is getting
> woken to just decrement a counter. The same deferral time can also
> achieved by simply doing the HPAGE_FRAG_CHECK_INTERVAL_MSEC <<
> COMPACT_MAX_DEFER_SHIFT thus unnecessary wakeup of kcompact thread is
> avoided thus also removes the need of 'proactive_defer' thread counter.
>
> Link: https://lore.kernel.org/linux-fsdevel/88abfdb6-2c13-b5a6-5b46-742d12d1c910@suse.cz/
> Signed-off-by: Charan Teja Reddy <charante@codeaurora.org>
With Andrew's comment fixup:
Acked-by: David Rientjes <rientjes@google.com>
Thanks, Charan.
prev parent reply other threads:[~2021-07-26 1:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 12:13 [PATCH resend] mm: compaction: optimize proactive compaction deferrals Charan Teja Reddy
2021-07-21 20:18 ` Andrew Morton
2021-07-21 21:29 ` Vlastimil Babka
2021-07-21 22:35 ` Khalid Aziz
2021-07-26 1:47 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83f046a3-5afc-fe6d-40dc-d7aee7b7e398@google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=charante@codeaurora.org \
--cc=khalid.aziz@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nigupta@nvidia.com \
--cc=vbabka@suse.cz \
--cc=vinmenon@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox