From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDBDC2773DA for ; Mon, 26 Jan 2026 06:33:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769409204; cv=none; b=fbamS3RsI3BOIF156jEHPCSb3mXgm/+pT8J4d09wcaNluywU+79zzbKFsjeLlWlAG2Cmht+oGxJEm4xrusaCm+TjMxu8IvfAibJ5jdrexrjfacev/xl2S9q8pyftF3iY4ew+ooJDSObZ5mMme7gmaFUEGEzj4WuSu2fC+qMnY9c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769409204; c=relaxed/simple; bh=EC8BKAcsOpPPEJnArc9xnjKjZWetOeHuGnnD7Ed12Mw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=JtAyO2nHVAp2/Nnz10/Q4ybSZph6S7NOhsqn1e5ESahsxIOyIxeJaL7dhcOU3PyMt2+7XW/wdWDcE1Dw2KtVQ7HOvgqxP02iFIsNOPeIrNDfdLUGDSyBwDmNRJkIGTtaPnxWJGUR44kl+roZePi2cq18ycwrT0dC7kLnnWB2rIo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=mF8rk6D0; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="mF8rk6D0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769409203; x=1800945203; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=EC8BKAcsOpPPEJnArc9xnjKjZWetOeHuGnnD7Ed12Mw=; b=mF8rk6D0Ro59zf+wta2WuKB7Ed6rGX8j/S0plBhMPZ7UxMgPVaUU3no5 hy4H5nBUW7QbqD+6uMeRtOlFCGb9zWxPhl1JFJfRc5OEKylTv9lgFATLz 1LBdf4+x56H7nxEF+Bs3V3etAshwSQNV5/kxBW5lwXvXqPClMMnj0f2Bv rKeX+T77jlWi0XRwnTiauaU3grKzpbK1czzZd3ooYbs/eqkEiFBiPRIK7 a3dTVxePbPcFU933i/WHggfuBlxVEjLHumLrw57TGcY5p9WaWdd97jZmb 52xrTQiYeqv7gbJfqEG2LASfmWlssLI+UCwFcuMevYVnl1er15SIN6lUS g==; X-CSE-ConnectionGUID: U6ff6blcTA+JbkueOA1kcQ== X-CSE-MsgGUID: NsppZv5gSkq4z7+pSU8ueA== X-IronPort-AV: E=McAfee;i="6800,10657,11682"; a="69781387" X-IronPort-AV: E=Sophos;i="6.21,254,1763452800"; d="scan'208";a="69781387" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2026 22:33:22 -0800 X-CSE-ConnectionGUID: n0sG5d3HRQyuwMJyVlKMkw== X-CSE-MsgGUID: 9Wdpytf0Qe+sxOQbP03XpA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,254,1763452800"; d="scan'208";a="212465698" Received: from black.igk.intel.com (HELO black) ([10.91.253.5]) by fmviesa004.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2026 22:33:20 -0800 From: Alexander Shishkin To: Thorsten Blum , Maxime Coquelin , Alexandre Torgue Cc: Thorsten Blum , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alexander.shishkin@linux.intel.com Subject: Re: [PATCH RESEND] stm class: Remove unnecessary local variable in stm_write In-Reply-To: <20260126004312.210402-2-thorsten.blum@linux.dev> References: <20260126004312.210402-2-thorsten.blum@linux.dev> Date: Mon, 26 Jan 2026 07:33:18 +0100 Message-ID: <83v7goano1.fsf@black.igk.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Thorsten Blum writes: > The local variable 'err' and the corresponding if check in stm_write() > are unnecessary. Remove them. Nice catch! Is this a result of manual code inspection or were any tools used, an AI agent or a coccinelle script or whatnot? Thanks, -- Alex