From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Tue, 15 Oct 2002 05:12:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Tue, 15 Oct 2002 05:12:36 -0400 Received: from dell-paw-3.cambridge.redhat.com ([195.224.55.237]:44797 "EHLO executor.cambridge.redhat.com") by vger.kernel.org with ESMTP id ; Tue, 15 Oct 2002 05:12:35 -0400 From: David Howells To: torvalds@transmeta.com Cc: linux-kernel@vger.kernel.org Subject: [PATCH] printk declaration bug User-Agent: EMH/1.14.1 SEMI/1.14.3 (Ushinoya) FLIM/1.14.3 (=?ISO-8859-4?Q?Unebigory=F2mae?=) APEL/10.3 Emacs/21.2 (i686-pc-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII Date: Tue, 15 Oct 2002 10:18:29 +0100 Message-ID: <8403.1034673509@warthog.cambridge.redhat.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, The attached patch removes a second, extraneous, and different declaration of printk() from asm-i386/spinlock.h. The difference is that the main one (in linux/kernel.h) is declared "asmlinkage" and is thus fixed to regparm(0). The second one isn't. David --- linux/include/asm-i386/spinlock.h.orig 2002-10-15 10:12:25.000000000 +0100 +++ linux/include/asm-i386/spinlock.h 2002-10-15 10:12:35.000000000 +0100 @@ -6,9 +6,6 @@ #include #include -extern int printk(const char * fmt, ...) - __attribute__ ((format (printf, 1, 2))); - /* * Your basic SMP spinlocks, allowing only a single CPU anywhere */