From: Pekka Enberg <penberg@gmail.com>
To: linux-os@analogic.com
Cc: Jesper Juhl <juhl-lkml@dif.dk>,
Neil Brown <neilb@cse.unsw.edu.au>,
nfs@lists.sourceforge.net,
Trond Myklebust <trond.myklebust@fys.uio.no>,
linux-kernel@vger.kernel.org, penberg@cs.helsinki.fi
Subject: Re: [PATCH] remove redundant NULL pointer checks prior to calling kfree() in fs/nfsd/
Date: Sun, 27 Mar 2005 17:00:01 +0300 [thread overview]
Message-ID: <84144f02050327060051b61e54@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0503251731240.6372@chaos.analogic.com>
On Fri, 25 Mar 2005 17:34:29 -0500 (EST), linux-os
<linux-os@analogic.com> wrote:
> You really should reconsider this activity. It is quite counter-productive.
No it's not. NULL is checked twice without Jesper's cleanups. If
kfree() calls are really that performance sensitive, just make it
inline and GCC will take care of it.
Pekka
prev parent reply other threads:[~2005-03-27 14:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-25 22:22 [PATCH] remove redundant NULL pointer checks prior to calling kfree() in fs/nfsd/ Jesper Juhl
2005-03-25 22:34 ` linux-os
2005-03-25 23:12 ` Jesper Juhl
2005-03-26 8:34 ` Arjan van de Ven
2005-03-27 12:45 ` Denis Vlasenko
2005-03-27 14:30 ` Arjan van de Ven
2005-03-27 14:00 ` Pekka Enberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f02050327060051b61e54@mail.gmail.com \
--to=penberg@gmail.com \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-os@analogic.com \
--cc=neilb@cse.unsw.edu.au \
--cc=nfs@lists.sourceforge.net \
--cc=penberg@cs.helsinki.fi \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox