From: Pekka Enberg <penberg@gmail.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: dpervushin@ru.mvista.com, linux-kernel@vger.kernel.org,
Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [RFC] SPI core
Date: Thu, 9 Jun 2005 20:41:14 +0300 [thread overview]
Message-ID: <84144f020506091041162df804@mail.gmail.com> (raw)
In-Reply-To: <200506092019.50210.adobriyan@gmail.com>
Hi,
On Thursday 09 June 2005 16:33, Pekka Enberg wrote:
> > Preferred location for EXPORT_SYMBOLs is immediately after the function
> > definition.
On 6/9/05, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> New files can choose any style.
Sure they can but hopefully they choose a style that make sense.
Putting EXPORT_SYMBOLs immediately after function definition makes
most sense to me. You can immediately see if a function is exported or
not plus you can get listing of all symbols with grep. So there's
really no good reason why you should put them at the end of a file
(and one good reason to put them after definition).
You are right, though, that authors and maintainers decide what style
they use. I only provide suggestions and hope for the best ;).
Pekka
next prev parent reply other threads:[~2005-06-09 17:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-31 16:09 [RFC] SPI core dmitry pervushin
2005-05-31 18:33 ` randy_dunlap
2005-05-31 20:44 ` Alexey Dobriyan
2005-05-31 21:41 ` NZG
2005-05-31 23:20 ` Greg KH
2005-05-31 23:32 ` Greg KH
2005-06-02 4:06 ` Mark M. Hoffman
2005-06-02 4:51 ` Greg KH
2005-06-02 13:02 ` Rui Sousa
2005-06-09 7:15 ` Greg KH
2005-06-09 10:39 ` Hinko Kocevar
2005-06-09 15:41 ` Lee Revell
2005-06-02 10:09 ` dmitry pervushin
2005-06-09 12:33 ` Pekka Enberg
2005-06-09 16:19 ` Alexey Dobriyan
2005-06-09 17:41 ` Pekka Enberg [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-06-01 1:19 David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020506091041162df804@mail.gmail.com \
--to=penberg@gmail.com \
--cc=adobriyan@gmail.com \
--cc=dpervushin@ru.mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox