Re: Patch of a new driver for kernel 2.4.x that need review

Pekka J Enberg
2005-07-07T06:59:24Z

Hi Dmitry,

Mark Gross writes:
> > > +
> > > +/* 0 = Dynamic allocation of the major device number */
> > > +#define TLCLK_MAJOR 252

Pekka J Enberg <penberg@cs.helsinki.fi> wrote:
> > Enums, please.
> >

Dmitry Torokhov writes:
> But not here - it is a single constant, not a value of a distinct type.

Fair enough, "static const int" would work here too. Defines should be
avoided because they allow you to override a value without ever noticing it.

Pekka