Re: Patch of a new driver for kernel 2.4.x that need review

Pekka Enberg
2005-08-09T07:17:21Z

On 8/8/05, Mark Gross <mgross@linux.intel.com> wrote:
> Please tell me what you think :)

The formatting seems completely messed up presumably because of your
email client.

On 8/8/05, Mark Gross <mgross@linux.intel.com> wrote:
> + alarm_events = kcalloc(sizeof(struct tlclk_alarms), 1, GFP_KERNEL);

The first argument to kcalloc() is number of elements and the second
one is size of one element. In this case, however, use the new
kzalloc() which can be found in 2.6.13-rc5-mm1.

Pekka