Re: Patch of a new driver for kernel 2.4.x that need review

Pekka J Enberg
2005-07-07T07:43:14Z

Hi Dmitry,

Pekka J Enberg <penberg@cs.helsinki.fi> wrote:
> > Fair enough, "static const int" would work here too. Defines should be
> > avoided because they allow you to override a value without ever noticing it.

Dmitry Torokhov writes:
> Would not this cause compiler to allocate memory for the constant?
> I suppose if GCC is really good it could eliminate allocation since
> nothing takes its address, but I am not sure.
>
> With #define you can be sure that it is just a constant expression.

Constant propagation pass will eliminate the allocation. I checked GCC 3.3.5
and does this with -O1.

Pekka