Re: [PATCH] [46/48] Suspend2 2.1.9.8 for 2.6.12: 622-swapwriter.patch

Nigel Cunningham
2005-07-08T13:44:15Z

Hi.

On Fri, 2005-07-08 at 07:26, nickpiggin@yahoo.com.au wrote:
> On Fri, 8 Jul 2005 07:16 am, Nigel Cunningham wrote:
>
> Hi,
>
> > > > +struct io_info {
> > > > + struct bio * sys_struct;
> > > > + long block[PAGE_SIZE/512];
> > >
> > > Aah, but for this you should use block_size(io_info->dev) instead. No
> > > need to mess with sector sizes. Why is this long by the way?
> > > PAGE_SIZE/512 is block size in bytes.
> >
> > No... it's the maximum number of blocks per page. Depending upon how
> > the user has set the blocksize when they created the filesystem (in the
> > case of filesystems), the number of blocks we use per page might be 1,
> > 2, 4 or 8.
> >
>
> MAX_BUF_PER_PAGE
>
> > It's long because a sector number is stored in it.
> >
>
> sector_t?

Fixed. Ta.

Nigel
--
Evolution.
Enumerate the requirements.
Consider the interdependencies.
Calculate the probabilities.
Be amazed that people believe it happened.