Re: [PATCH] [14/48] Suspend2 2.1.9.8 for 2.6.12: 404-check-mounts-support.patch

Nigel Cunningham
2005-07-06T10:54:28Z

Hi.

Sorry.

It's not really a bug in the swapoff code. Rather, clearing this field
allows simple identification of the devices being used for swap (for
flushing writes).

Regards,

Nigel

On Wed, 2005-07-06 at 18:15, Pavel Machek wrote:
> On St 06-07-05 12:20:40, Nigel Cunningham wrote:
> > diff -ruNp 405-clear-swapfile-bdev-in-swapoff.patch-old/mm/swapfile.c 405-clear-swapfile-bdev-in-swapoff.patch-new/mm/swapfile.c
> > --- 405-clear-swapfile-bdev-in-swapoff.patch-old/mm/swapfile.c 2005-07-06 11:22:01.000000000 +1000
> > +++ 405-clear-swapfile-bdev-in-swapoff.patch-new/mm/swapfile.c 2005-07-04 23:14:19.000000000 +1000
> > @@ -1162,6 +1162,7 @@ asmlinkage long sys_swapoff(const char _
> > swap_file = p->swap_file;
> > p->swap_file = NULL;
> > p->max = 0;
> > + p->bdev = NULL;
> > swap_map = p->swap_map;
> > p->swap_map = NULL;
> > p->flags = 0;
>
> I guess some explanation is needed here; and if it is bugfix it should
> just go in...
> Pavel
--
Evolution.
Enumerate the requirements.
Consider the interdependencies.
Calculate the probabilities.
Be amazed that people believe it happened.