Re: [PATCH] [28/48] Suspend2 2.1.9.8 for 2.6.12: 605-kernel_power_suspend.patch

Pavel Machek
2005-07-10T17:58:04Z

Hi!

> diff -ruNp 606-all-settings.patch-old/kernel/power/suspend2_core/all_settings.c 606-all-settings.patch-new/kernel/power/suspend2_core/all_settings.c
> --- 606-all-settings.patch-old/kernel/power/suspend2_core/all_settings.c 1970-01-01 10:00:00.000000000 +1000
> +++ 606-all-settings.patch-new/kernel/power/suspend2_core/all_settings.c 2005-07-04 23:14:19.000000000 +1000
> @@ -0,0 +1,325 @@
> +/*
> + * /kernel/power/suspend2_core/all_settings.c
> + *
> + * Suspend2 is released under the GPLv2.
> + *
> + * Copyright (C) 2002-2005 Nigel Cunningham <nigel@suspend2.net>
> + *
> + * This file provides the all_settings proc entry, used to save
> + * and restore all suspend2 settings en masse.
> + */
> +
> +#include <linux/mm.h>
> +#include <linux/suspend.h>
> +#include <asm/uaccess.h>
> +
> +#include "plugins.h"
> +#include "proc.h"
> +#include "suspend2_common.h"
> +#include "prepare_image.h"
> +#include "power_off.h"
> +#include "io.h"
> +
> +#define ALL_SETTINGS_VERSION 4
> +
> +static int resume2_len;
> +
> +/*
> + * suspend_write2_compat_proc.
> + *
> + * This entry allows all of the settings to be set at once.
> + * It was originally for compatibility with pre- /proc/suspend
> + * versions, but has been retained because it makes saving and
> + * restoring the configuration simpler.
> + */

Okay, and it is also extremely ugly. Now you have chance to clean it
up, please drop it.
Pavel

--
teflon -- maybe it is a trademark, but it should not be.