Re: [PATCH] [26/48] Suspend2 2.1.9.8 for 2.6.12: 603-suspend2_common-headers.patch

Nigel Cunningham
2005-07-06T15:51:47Z

Hi.

On Wed, 2005-07-06 at 20:22, Pekka Enberg wrote:
> > diff -ruNp 604-utility-header.patch-old/kernel/power/suspend2_core/utility.h 604-utility-header.patch-new/kernel/power/suspend2_core/utility.h
> > --- 604-utility-header.patch-old/kernel/power/suspend2_core/utility.h 1970-01-01 10:00:00.000000000 +1000
> > +++ 604-utility-header.patch-new/kernel/power/suspend2_core/utility.h 2005-07-05 23:48:59.000000000 +1000
>
> Please do move these.

Okay.

> > +
> > +extern int suspend_snprintf(char * buffer, int buffer_size, const char *fmt, ...);
>
> What's wrong with regular snprintf?

If there's a buffer overrun, it returns the number of bytes it wanted to
use, not the number actually used.

Regards,

Nigel
--
Evolution.
Enumerate the requirements.
Consider the interdependencies.
Calculate the probabilities.
Be amazed that people believe it happened.