From: Pekka Enberg <penberg@cs.helsinki.fi>
To: "Machida, Hiroyuki" <machida@sm.sony.co.jp>
Cc: linux-kernel@vger.kernel.org, hirofumi@mail.parknet.co.jp
Subject: Re: [PATCH][FAT] FAT dirent scan with hin take #3
Date: Wed, 31 Aug 2005 16:53:45 +0300 [thread overview]
Message-ID: <84144f0205083106534c8623a7@mail.gmail.com> (raw)
In-Reply-To: <84144f0205083106517f67d057@mail.gmail.com>
On 8/31/05, Pekka Enberg <penberg@cs.helsinki.fi> wrote:
> After finally understanding what you're doing, how about:
>
> static inline int hint_allocate(struct inode *dir)
> {
> loff_t *hints;
> int err = 0;
>
> if (!MSDOS_I(dir)->scan_hints)
Should read:
if (MSDOS_I(dir)->scan_hints)
> return 0;
>
> hints = kcalloc(FAT_SCAN_NWAY, sizeof(loff_t), GFP_KERNEL);
> if (!hints)
> err = -ENOMEM;
>
> down(&MSDOS_I(dir)->scan_lock);
> /*
> * We allocated memory without scan_lock so lets make sure
> * no other thread completed hint_allocate() before us.
> */
> if (!MSDOS_I(dir)->scan_hints) {
> MSDOS_I(dir)->scan_hints = hints;
> hints = NULL;
> }
> up(&MSDOS_I(dir)->scan_lock);
>
> kfree(hints);
> return err;
> }
>
> Pekka
>
next prev parent reply other threads:[~2005-08-31 13:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-30 3:01 [RFC][FAT] diren scan profiling report Machida, Hiroyuki
2005-08-30 4:50 ` [PATCH][FAT] FAT dirent scan with hin take #2 Machida, Hiroyuki
2005-08-30 8:51 ` Pekka Enberg
2005-08-30 8:55 ` Pekka Enberg
2005-08-30 9:18 ` Vojtech Pavlik
2005-08-30 19:27 ` OGAWA Hirofumi
2005-08-31 1:43 ` OGAWA Hirofumi
2005-08-31 8:25 ` [PATCH][FAT] FAT dirent scan with hin take #3 Machida, Hiroyuki
2005-08-31 10:00 ` Pekka Enberg
2005-08-31 12:57 ` Machida, Hiroyuki
2005-08-31 13:51 ` Pekka Enberg
2005-08-31 13:53 ` Pekka Enberg [this message]
2005-08-31 10:03 ` Pekka Enberg
2005-08-31 13:27 ` Machida, Hiroyuki
2005-08-31 10:14 ` Pekka Enberg
2005-08-31 13:04 ` Machida, Hiroyuki
2005-08-31 13:52 ` Pekka Enberg
2005-08-31 16:41 ` OGAWA Hirofumi
2005-09-01 5:50 ` Machida, Hiroyuki
2005-09-01 7:45 ` Machida, Hiroyuki
2005-09-01 17:48 ` OGAWA Hirofumi
2005-09-14 18:59 ` Machida, Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f0205083106534c8623a7@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=machida@sm.sony.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox