From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Richard Purdie <rpurdie@rpsys.net>
Cc: Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
Russell King <rmk+lkml@arm.linux.org.uk>
Subject: Re: [-mm patch 2/5] SharpSL: Add cxx00 support to the Corgi LCD driver
Date: Tue, 6 Sep 2005 15:10:47 +0300 [thread overview]
Message-ID: <84144f0205090605107a76dd78@mail.gmail.com> (raw)
In-Reply-To: <1126007628.8338.127.camel@localhost.localdomain>
On 9/6/05, Richard Purdie <rpurdie@rpsys.net> wrote:
> +/*
> + * Corgi/Spitz Touchscreen to LCD interface
> + */
> +unsigned long inline corgi_get_hsync_len(void)
> +{
> + if (machine_is_corgi() || machine_is_shepherd() || machine_is_husky()) {
> +#ifdef CONFIG_PXA_SHARP_C7xx
> + return w100fb_get_hsynclen(&corgifb_device.dev);
> +#endif
> + } else if (machine_is_spitz() || machine_is_akita() || machine_is_borzoi()) {
> +#ifdef CONFIG_PXA_SHARP_Cxx00
> + return pxafb_get_hsync_time(&pxafb_device.dev);
> +#endif
> + }
> + return 0;
> +}
Please consider making two version of corgi_get_hsync_len() instead
for both config options. The above is hard to read.
Pekka
next prev parent reply other threads:[~2005-09-06 12:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-06 11:53 [-mm patch 2/5] SharpSL: Add cxx00 support to the Corgi LCD driver Richard Purdie
2005-09-06 12:10 ` Pekka Enberg [this message]
2005-09-06 12:14 ` Pekka Enberg
2005-09-08 12:34 ` Russell King
2005-09-08 15:06 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f0205090605107a76dd78@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox