The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: Louis Sautier <sautier.louis@gmail.com>
Cc: Sathya Prakash <sathya.prakash@broadcom.com>,
	Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
	Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
	Ranjan Kumar <ranjan.kumar@broadcom.com>,
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Guenter Roeck <linux@roeck-us.net>,
	MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 RESEND 2/2] scsi: mpt3sas: add hwmon support
Date: Mon, 22 Jun 2026 20:28:48 +0900	[thread overview]
Message-ID: <841e8ff7-12db-4ca4-aaa5-fb8accfc9df0@kernel.org> (raw)
In-Reply-To: <ajkaf0aa0TWXdRZW@localhost>

On 6/22/26 20:20, Louis Sautier wrote:
> On Fri, 12 Jun 2026 08:34:13 +0900, Damien Le Moal wrote:
>>> If I dropped SCSI_MPT3SAS_HWMON, I would use
>>> "#if IS_REACHABLE(CONFIG_HWMON)" to match what i915_hwmon.h and
>>> xe_hwmon.h do and properly handle the SCSI_MPT3SAS=y and HWMON=m case.
>>> What do you think?
>>
>> That seems appropriate. If there is a clean way to avoid adding the new config
>> option, we should use that method.
> 
> Hi Damien,
> 
> I did this in v4. Could you please review it?

I saw only patch 1/2... I was waiting for the new version of the full series.

> 
> https://lore.kernel.org/linux-hwmon/20260613023833.3163507-1-sautier.louis@gmail.com/


-- 
Damien Le Moal
Western Digital Research

      reply	other threads:[~2026-06-22 11:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-09 16:44 [PATCH v3 RESEND 0/2] scsi: mpt3sas: add hwmon support Louis Sautier
2026-06-09 16:44 ` [PATCH v3 RESEND 1/2] scsi: mpt3sas: add IO Unit Page 7 config accessor Louis Sautier
2026-06-10  0:12   ` Damien Le Moal
2026-06-11 16:38     ` Louis Sautier
2026-06-11 23:32       ` Damien Le Moal
2026-06-09 16:44 ` [PATCH v3 RESEND 2/2] scsi: mpt3sas: add hwmon support Louis Sautier
2026-06-10  0:22   ` Damien Le Moal
2026-06-11 16:39     ` Louis Sautier
2026-06-11 23:34       ` Damien Le Moal
2026-06-22 11:20         ` Louis Sautier
2026-06-22 11:28           ` Damien Le Moal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=841e8ff7-12db-4ca4-aaa5-fb8accfc9df0@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=MPT-FusionLinux.pdl@broadcom.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=martin.petersen@oracle.com \
    --cc=ranjan.kumar@broadcom.com \
    --cc=sathya.prakash@broadcom.com \
    --cc=sautier.louis@gmail.com \
    --cc=sreekanth.reddy@broadcom.com \
    --cc=suganath-prabu.subramani@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox