* [PATCH 1/1] thermal/drivers/imx_sc_thermal: Use dev_err_probe
@ 2024-07-17 8:55 Alexander Stein
2024-09-04 11:48 ` Alexander Stein
2024-09-04 13:35 ` Daniel Lezcano
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Stein @ 2024-07-17 8:55 UTC (permalink / raw)
To: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: Alexander Stein, linux-pm, imx, linux-arm-kernel, linux-kernel
This adds the error code to the error message and also stores that
message in case of probe deferral.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
drivers/thermal/imx_sc_thermal.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c
index 7224f8d21db97..88558ce588807 100644
--- a/drivers/thermal/imx_sc_thermal.c
+++ b/drivers/thermal/imx_sc_thermal.c
@@ -111,8 +111,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev)
if (ret == -ENODEV)
continue;
- dev_err(&pdev->dev, "failed to register thermal zone\n");
- return ret;
+ return dev_err_probe(&pdev->dev, ret, "failed to register thermal zone\n");
}
devm_thermal_add_hwmon_sysfs(&pdev->dev, sensor->tzd);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] thermal/drivers/imx_sc_thermal: Use dev_err_probe
2024-07-17 8:55 [PATCH 1/1] thermal/drivers/imx_sc_thermal: Use dev_err_probe Alexander Stein
@ 2024-09-04 11:48 ` Alexander Stein
2024-09-04 13:35 ` Daniel Lezcano
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Stein @ 2024-09-04 11:48 UTC (permalink / raw)
To: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: linux-pm, imx, linux-arm-kernel, linux-kernel
Hi,
Am Mittwoch, 17. Juli 2024, 10:55:16 CEST schrieb Alexander Stein:
> This adds the error code to the error message and also stores that
> message in case of probe deferral.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> drivers/thermal/imx_sc_thermal.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c
> index 7224f8d21db97..88558ce588807 100644
> --- a/drivers/thermal/imx_sc_thermal.c
> +++ b/drivers/thermal/imx_sc_thermal.c
> @@ -111,8 +111,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev)
> if (ret == -ENODEV)
> continue;
>
> - dev_err(&pdev->dev, "failed to register thermal zone\n");
> - return ret;
> + return dev_err_probe(&pdev->dev, ret, "failed to register thermal zone\n");
> }
>
> devm_thermal_add_hwmon_sysfs(&pdev->dev, sensor->tzd);
>
Ping! Any feedback?
Thanks,
Alexander
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] thermal/drivers/imx_sc_thermal: Use dev_err_probe
2024-07-17 8:55 [PATCH 1/1] thermal/drivers/imx_sc_thermal: Use dev_err_probe Alexander Stein
2024-09-04 11:48 ` Alexander Stein
@ 2024-09-04 13:35 ` Daniel Lezcano
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Lezcano @ 2024-09-04 13:35 UTC (permalink / raw)
To: Alexander Stein, Rafael J. Wysocki, Zhang Rui, Lukasz Luba,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: linux-pm, imx, linux-arm-kernel, linux-kernel
On 17/07/2024 10:55, Alexander Stein wrote:
> This adds the error code to the error message and also stores that
> message in case of probe deferral.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-04 13:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-17 8:55 [PATCH 1/1] thermal/drivers/imx_sc_thermal: Use dev_err_probe Alexander Stein
2024-09-04 11:48 ` Alexander Stein
2024-09-04 13:35 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox