From: Jens Axboe <axboe@kernel.dk>
To: Oleg Nesterov <oleg@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] task_work: add helper for more targeted task_work canceling
Date: Wed, 7 Apr 2021 09:37:15 -0600 [thread overview]
Message-ID: <8436db10-1db6-a756-b060-7ec3222f2e55@kernel.dk> (raw)
In-Reply-To: <20210406174729.GC13270@redhat.com>
On 4/6/21 11:47 AM, Oleg Nesterov wrote:
> On 04/04, Jens Axboe wrote:
>>
>> +struct callback_head *task_work_cancel_match(struct task_struct *task,
>> + bool (*match)(struct callback_head *, void *data), void *data);
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> Feel free to ignore, but how about "typedef task_work_match_t" ?
>
> Either way,
>
> Reviewed-by: Oleg Nesterov <oleg@redhat.com>
Thanks! I actually didn't add that deliberately, as I think they just
tend to hide it. If I see the above, I know what the callback func
looks like without having to find the definition of task_work_match_t.
--
Jens Axboe
prev parent reply other threads:[~2021-04-07 15:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-04 23:00 [PATCH] task_work: add helper for more targeted task_work canceling Jens Axboe
2021-04-06 17:47 ` Oleg Nesterov
2021-04-07 15:37 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8436db10-1db6-a756-b060-7ec3222f2e55@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox