Re: [PATCH 1/2] dt-bindings: iio: light: add ltr390

Anshul Dalal
2023-11-09T10:37:06Z

Hello Krzysztof,

On 11/9/23 15:57, Krzysztof Kozlowski wrote:
> On 09/11/2023 10:04, Anshul Dalal wrote:
>> Add binding for Lite-On LTR390 which is an Ambient/UV light sensor that
>> communicates over i2c with an address of 0x53.
>>
>> Datasheet:
>> https://optoelectronics.liteon.com/upload/download/DS86-2015-0004/LTR-390UV_Final_%20DS_V1%201.pdf
>>
>> Signed-off-by: Anshul Dalal <anshulusr@gmail.com>
>
>
>> + interrupts:
>> + maxItems: 1
>> + description: |
>> + Level interrupt pin with open drain output.
>> + The sensor pulls this pin low when the measured reading is greater than
>> + some configured threshold.
>> +
>> + vdd-supply: true
>> +
>> +required:
>> + - compatible
>> + - reg
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + i2c {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + light-sensor@53 {
>> + compatible = "liteon,ltr390";
>> + reg = <0x53>;
>
> Please extend the example to be complete - interrupts and vdd-supply.

Could the following be used as a suitable example.

#include <dt-bindings/interrupt-controller/irq.h>

i2c {
#address-cells = <1>;
#size-cells = <0>;

light-sensor@53 {
compatible = "liteon,ltr390";
reg = <0x53>;
interrupts = <18 IRQ_TYPE_EDGE_FALLING>;
vdd-supply = <&vdd_regulator>;
};
};

Thanks for the review.

Best regards,
Anshul