Re: [PATCH 13/26] ARM: tegra: colibri_t30: use proper irq-gpio for stmpe811

Marcel Ziswiler
2018-08-29T14:57:07Z

On Thu, 2018-07-26 at 10:07 +0200, Stefan Agner wrote:
> On 23.07.2018 14:36, Marcel Ziswiler wrote:
> > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> >
> > Use proper irq-gpio for stmpe811 touch controller.
>
> I don't think this change is necessary, interrupts/interrupt-parent
> specification seems to be supported by the driver as well.

Yes, however, should you look at the driver more closely you may notice
that only if using irq-gpio the GPIO in question also does get properly
requested by devm_gpio_request_one() with an "stmpe" label. So I really
do think doing it this way is advantageous. I did notice this
difference by chance when fighting some probe defer issues earlier.

> --
> Stefan
>
> >
> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> >
> > ---
> >
> > arch/arm/boot/dts/tegra30-colibri.dtsi | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/tegra30-colibri.dtsi
> > b/arch/arm/boot/dts/tegra30-colibri.dtsi
> > index c80b9bf44752..ace72a53186a 100644
> > --- a/arch/arm/boot/dts/tegra30-colibri.dtsi
> > +++ b/arch/arm/boot/dts/tegra30-colibri.dtsi
> > @@ -836,8 +836,7 @@
> > stmpe811@41 {
> > compatible = "st,stmpe811";
> > reg = <0x41>;
> > - interrupts = <TEGRA_GPIO(V, 0)
> > IRQ_TYPE_LEVEL_LOW>;
> > - interrupt-parent = <&gpio>;
> > + irq-gpio = <&gpio TEGRA_GPIO(V, 0)
> > IRQ_TYPE_LEVEL_LOW>;
> > interrupt-controller;
> > id = <0>;
> > blocks = <0x5>;