linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "seanjc@google.com" <seanjc@google.com>
Subject: Re: [PATCH] KVM: Documentation: document how KVM is tested
Date: Thu, 10 Jul 2025 17:44:42 +0000	[thread overview]
Message-ID: <844d7aeec492704bead16ebe163c908deaac8301.camel@intel.com> (raw)
In-Reply-To: <20250710102917.250176-1-pbonzini@redhat.com>

On Thu, 2025-07-10 at 12:29 +0200, Paolo Bonzini wrote:
> +Bigger features, usually spanning host and guest
> +  These should be supported by Linux guests, with limited exceptions
> +  for Hyper-V features that are testable on Windows guests.  It is
> +  strongly suggested that the feature be usable exclusively with open
> +  source code, including in at least one of QEMU or crosvm.  Selftests

"be usable exclusively with open source code" might be a little ambiguous. I
think you mean should be usable without any closed source components. But, it
might be read that it should not be used with closed source components.

I think you also don't mean host firmware, etc.

Maybe clearer?
   It is strongly suggested that the feature be usable with a full stack of open
   source userspace and guest, including in at least one of QEMU or crosvm.

And thanks for clarifying the policy!

> +  should test at least API error cases.  Guest operation can be
> +  covered by either selftests of ``kvm-unit-tests`` (this is especially
> +  important for paravirtualized and Windows-only features).  Strong
> +  selftest coverage can also be a replacement for implementation in an
> +  open source VMM, but this is generally not recommended.
> +
> +Following the above suggestions for testing in selftests and
> +``kvm-unit-tests`` will make it easier for the maintainers to review
> +and accept your code.  In fact, even before you contribute your changes
> +upstream it will make it easier for you to develop for KVM.
> +
> +Of course, the KVM maintainers reserve the right to require more tests,
> +though they may also waive the requirement from time to time.


  reply	other threads:[~2025-07-10 17:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-10 10:29 [PATCH] KVM: Documentation: document how KVM is tested Paolo Bonzini
2025-07-10 17:44 ` Edgecombe, Rick P [this message]
2025-07-10 22:26 ` Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=844d7aeec492704bead16ebe163c908deaac8301.camel@intel.com \
    --to=rick.p.edgecombe@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).